From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFDA7C4345F for ; Sat, 27 Apr 2024 04:51:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 504BB6B0085; Sat, 27 Apr 2024 00:51:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B5216B0087; Sat, 27 Apr 2024 00:51:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37CE26B0088; Sat, 27 Apr 2024 00:51:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 188536B0085 for ; Sat, 27 Apr 2024 00:51:08 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8888F808FC for ; Sat, 27 Apr 2024 04:51:07 +0000 (UTC) X-FDA: 82054087374.18.66ED1CE Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) by imf18.hostedemail.com (Postfix) with ESMTP id C9E851C0007 for ; Sat, 27 Apr 2024 04:51:05 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=YqOgqzzI; spf=pass (imf18.hostedemail.com: domain of rientjes@google.com designates 209.85.166.177 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714193465; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=whA25CE6KCsgd3fm7zWRdBBM3FYw588FlW5NJVxj+6E=; b=kiEZyXj7fWW6qvxmml/CcdejkXGc3j0Ynja7bQmaqDg98eyupEajzspfDzFwfDRcztHOYd kK2LGf9qWwiL6uddWx2NKfKNEY1UuYQydxhZFVdbWoKMCPFcLE2/aE70w4fnXzhpaqGSIc e7jlvNF0SFSJYU7EzlP0+BoDlRl4bY4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714193465; a=rsa-sha256; cv=none; b=JrlHq6YU1n+1EO6aBGvUcN2JybjD1cFjvKy1LDgLPcEKCZ+omub+CzPKf1ruJBDEIlbpGm DgDteCRvN3GdUr7yh7XEH+3QUBF/8rWWE6P2TwPG14SB8RsherZBd6nuoChxF+TM4GTaVF 8dX+0vTt5oa8F4jt3wognhTZqnSy/vY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=YqOgqzzI; spf=pass (imf18.hostedemail.com: domain of rientjes@google.com designates 209.85.166.177 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-36c3a731125so67485ab.0 for ; Fri, 26 Apr 2024 21:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714193465; x=1714798265; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=whA25CE6KCsgd3fm7zWRdBBM3FYw588FlW5NJVxj+6E=; b=YqOgqzzIuGRddWSSgELi2YUafV3kR+o2bRZ39dbnyVChcK76U9Yo0WnxqbipXEqIod sozIRuWipgw8wvVihpvBPNXyU3Wijot6DtwCZczLxgbYjNT1TxS82t0wHU+v5PWwdk5x yEasuLxKP/kVh4A8DPeyos/ZwTnVc8ErLYmViUnUtox/6mb2yibQMrC9bVym0eMGUe5i yAouRgod+T70AGRB/n1g2yPyYdziW02HvPL1Do8NYK+T5NQuJJH2wHfd/FFppjLczyJr 6F2JwhdjKWbHZieR9JoEaqmkjGNPCyQPDpnMvuyme9hFsYvxU9CC67XRhcn3EwyU7QS0 7T7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714193465; x=1714798265; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=whA25CE6KCsgd3fm7zWRdBBM3FYw588FlW5NJVxj+6E=; b=wyDCyy/W/yAObsguXZxiDMCcD9s/19rk4bOAwBF6wt/M4A15fSUyUvk3N5uYu8R6B5 jgqhp0OnKM87ONYVAJgHwu6CkZWtoHing82eO5Igt4z3C6frWPnKsHQz7hXjgGsnlyhw V6YX5Da3S2ZOq4rlQM4XN9y66SscOQ2x3S/nU00RZIs2WvQAtwpoxm98fe2Vt0oOiZPF vRpi7a30tM6KLWSrhn8rkqCje6gNXC84TkDnHU8nUZP+zqsJcrqDk6G8370u7OyQl2+Q V7F+o1d2b5W+rohOdaEDzptY2MXkPFOW0v+jJ9aCxlgZQqsbMWz8hokcb/vvicPWC3Og MmeQ== X-Gm-Message-State: AOJu0YytniDc8gSodNVAKiM4sQCAbk2Fm1RfqzqngJHfa2soG0aaL2a5 fhXgDMYeuBRFmwt4vVBNn+tBXCwCbHGSv5WzYTMjNwOrdAoPLk2KpiHmushmng== X-Google-Smtp-Source: AGHT+IG3QKIni8VS1MzqvmL7NNckE2yDqVFMMvU9UWIQOcVTByH3hlUFJpqxSUfC3xCohEhfAb+Vpg== X-Received: by 2002:a92:d2ca:0:b0:36c:560:2586 with SMTP id w10-20020a92d2ca000000b0036c05602586mr81830ilg.23.1714193464626; Fri, 26 Apr 2024 21:51:04 -0700 (PDT) Received: from [2620:0:1008:15:127e:6b08:ad38:79c9] ([2620:0:1008:15:127e:6b08:ad38:79c9]) by smtp.gmail.com with ESMTPSA id ka1-20020a056a00938100b006ecfb733248sm16132340pfb.13.2024.04.26.21.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 21:51:04 -0700 (PDT) Date: Fri, 26 Apr 2024 21:51:03 -0700 (PDT) From: David Rientjes To: Hyunmin Lee cc: linux-mm@kvack.org, Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jeungwoo Yoo , Sangyun Kim , Gwan-gyeong Mun Subject: Re: [PATCH v3 1/2] mm/slub: create kmalloc 96 and 192 caches regardless cache size order In-Reply-To: <20240424140422.12780-2-hyunminlr@gmail.com> Message-ID: <56ca6014-3a8f-c5bc-99da-d68547c2c80b@google.com> References: <20240424140422.12780-1-hyunminlr@gmail.com> <20240424140422.12780-2-hyunminlr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Stat-Signature: xzjqq1et86ka3inkpzdiejyon1uym88g X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C9E851C0007 X-HE-Tag: 1714193465-191374 X-HE-Meta: U2FsdGVkX18dK6i3xz2V6RJXjxrkKLL+1PC8MB6gRWf28WSNY8kKkQcgANtbnANZ4tY0P+/eFd/NpbWRK9OQGP1YYhQsw57LLDMUb3K2B44S8JszNqQLS/d+aPVKwzIjTkZQk9IN7bkzllJv91yoaPXFvJdFjnxGUz6opRg8VO2e4LfgS8WFViKQvK5R19IK4YXZoCVbEhXB7UU7xzSV3YLUe3HUCGCtkwGe3ZyEGUTk1i5HDoqv5pQPeLyYKcNHth9GOTu+n8NjrXdu4GFMjzBEi8ynSMFv2ZueGKkHdk2TA5rqaDN/86iqif7wBUPc6IqG3ldud+C7TyDSopQ+JENCMQz99tmh6W+9rjVOwt6nynTCcbMylbEen4MMbYRMDyQASykjF9UPrQwJghjs0ahPIiuP0HHHQ86URKzg6tjNl4f0NEizmqH62kvHgAL2xQNTmaQaY7e/lfipzmd09b05EF/uxKjO+a+YVv59yMUiFgH6zWpb7eskuUa6t6wF16A+WfX15YnsjUbxFcFNTGq/2mlgf+rdlztu6L41sMuYEfe+wDCAnMrxkd/rj8HdAUbHPIL9qBsUkDO7MQS6ZrGmXpzIo+xhzMydNXLGWy+JxefMmA1hEKB6ZKYGNpzFyF2OaIJRu1HB3UvsFHbTcUs3JYbFUozSdp9fkW0n219N/MVZUCGe2JqKpOcB5W+3ROh9gd1yGvhTdN6SRel0bWl3gsd+SBVVvlFx4roQ2cXKJCkmydZRQtqzsM5b3T6ILaY4C0pOTgKkttHGpBsHnO/84v1wKEQz5ta6vZhowsUDlHPs5tYGFJi676OFmQ1py+KLutZD1Hhgus7YEutEP2fWgelKJhuibiqXpwyOLcSd1I3MBUl3SySznoWqab1+PpxN+nh5m1XuWULi0oRy+N2CsfPF2zHvo/M/iXjWTNviTAeoTciHbRL82iP/OnDnj3r0X/5VxxjMOn4muTG WJxg4y2A Zpw2SYDbexFoBzCc+N/XgLrMwi7M1hO/q8m5MGg5fVpzVzK8WsoO+0w8qRHEUxgMxTr+zHrjR/gacKAh/rXUNAUBIXQ5GY0+S+on/0rKk/Z6dBSR3aeCh0Iy260hXxiPHmh2aXrCfEcmik325146a8KW/bZX3Cny087bR6tWN1TS3BSC9dazOdX0/nLoqowqDe7JduJF3JyU4r61uoRa3t6OG6R0RemnuLsZfkGG+E9ftwE1chinYff8xQdFQPFawRPbpWtlKFtqRzF+gZo8Kxy/GQiLbOUSUfBA3thV58Q/RYpM6A79V7X1+3lXxmIwqs1Gun17B2hyyIPPLAhKe7qzY+zQBQwmCknPfFt+GyisbrdfcVQ0eBbZEbM7ztMdLtU/nM57jYEZEOusBdiqTzq40LJMcmzF/Aw/5wIdeiJbYGkLkB05/TaALrFtmD8KF/hy/MB8ke4b+KnpRy5WFyrbNGt818sIUL5j1lh8wF+RkIO4H4XehgmZVAHRFvHcUs7oGTJ2QMr7D4ICE0WhZmhZZv23MDTo07kVi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000685, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 24 Apr 2024, Hyunmin Lee wrote: > For SLAB the kmalloc caches needed to be created in ascending sizes in > order. However, the constraint is not necessary anymore because SLAB has > been removed and SLUB doesn't need to comply with the constraint. Thus, > kmalloc 96 and 192 caches can be created after the other size kmalloc > caches are created instead of checking every time to find their order to > be created. Also, this change could prevent engineers from being confused > by the removed constraint. > > Signed-off-by: Hyunmin Lee > Co-developed-by: Jeungwoo Yoo > Signed-off-by: Jeungwoo Yoo > Co-developed-by: Sangyun Kim > Signed-off-by: Sangyun Kim > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Cc: Gwan-gyeong Mun Acked-by: David Rientjes