From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Coco Li <lixiaoyan@google.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>,
Mubashir Adnan Qureshi <mubashirq@google.com>,
Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, Chao Wu <wwchao@google.com>,
Wei Wang <weiwan@google.com>
Subject: Re: [PATCH v1 net-next 3/5] netns-ipv4: reorganize netns_ipv4 fast path variables
Date: Sun, 17 Sep 2023 18:10:11 +0100 [thread overview]
Message-ID: <56d32e37-afdd-342c-947d-dec329a504e5@linux.dev> (raw)
In-Reply-To: <20230916010625.2771731-4-lixiaoyan@google.com>
On 16/09/2023 02:06, Coco Li wrote:
> Reorganize fast path variables on tx-txrx-rx order.
> Fastpath cacheline ends after sysctl_tcp_rmem.
> There are only read-only variables here. (write is on the control path
> and not considered in this case)
I believe udp sysctls can be aligned the same way. With HTTP/3 adoption
we should think about UDP traffic too, and looks like we do have some
space in hot-path cache lines for udp_early_demux and rmem/wmem.
And have you thought about cache-line boundary alignment for these values?
next prev parent reply other threads:[~2023-09-17 17:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 1:06 [PATCH v1 net-next 0/5] Analyze and Reorganize core Networking Structs to optimize cacheline consumption Coco Li
2023-09-16 1:06 ` [PATCH v1 net-next 1/5] Documentations: Analyze heavily used Networking related structs Coco Li
2023-09-16 14:36 ` Andrew Lunn
2023-09-21 6:38 ` Coco Li
2023-10-04 13:37 ` Jakub Kicinski
2023-10-04 13:41 ` Jakub Kicinski
2023-10-17 1:37 ` Coco Li
2023-09-16 1:06 ` [PATCH v1 net-next 2/5] net-smnp: reorganize SNMP fast path variables Coco Li
2023-09-16 3:16 ` David Ahern
2023-09-16 14:39 ` Andrew Lunn
2023-09-16 1:06 ` [PATCH v1 net-next 3/5] netns-ipv4: reorganize netns_ipv4 " Coco Li
2023-09-16 3:17 ` David Ahern
2023-09-17 17:10 ` Vadim Fedorenko [this message]
2023-09-21 6:31 ` Coco Li
2023-09-16 1:06 ` [PATCH v1 net-next 4/5] net-device: reorganize net_device " Coco Li
2023-09-16 3:17 ` David Ahern
2023-09-18 19:50 ` Eric Dumazet
2023-09-16 1:06 ` [PATCH v1 net-next 5/5] tcp: reorganize tcp_sock " Coco Li
2023-09-16 3:17 ` David Ahern
2023-09-16 3:20 ` [PATCH v1 net-next 0/5] Analyze and Reorganize core Networking Structs to optimize cacheline consumption David Ahern
2023-09-16 14:23 ` Andrew Lunn
2023-09-21 6:47 ` Coco Li
2023-10-17 1:41 ` Coco Li
2023-10-17 11:26 ` Sunil Kovvuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56d32e37-afdd-342c-947d-dec329a504e5@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lixiaoyan@google.com \
--cc=mubashirq@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiwan@google.com \
--cc=wwchao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.