All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Mario Limonciello <superm1@kernel.org>,
	mario.limonciello@amd.com, lee@kernel.org, aaro.koskinen@iki.fi,
	andreas@kemnade.info, khilman@baylibre.com, rogerq@kernel.org,
	tony@atomide.com, tglx@linutronix.de,
	Arnd Bergmann <arnd@arndb.de>,
	Nathan Chancellor <nathan@kernel.org>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] mfd: Fix compilation without CONFIG_OF
Date: Wed, 11 Jun 2025 12:32:13 +0200	[thread overview]
Message-ID: <56d755fb-67d2-414a-bb49-7444a55332cb@kernel.org> (raw)
In-Reply-To: <a3754c77-b85c-48f7-aacf-b50725b2dd01@kernel.org>

On 09. 06. 25, 10:31, Jiri Slaby wrote:
> On 09. 06. 25, 10:29, Jiri Slaby wrote:
>> On 02. 06. 25, 22:09, Mario Limonciello wrote:
>>> From: Mario Limonciello <mario.limonciello@amd.com>
>>>
>>> When compiling without CONFIG_OF but with CONFIG_WERROR enabled
>>> several mfd drivers fail with -Werror=unused-variable.
>>>
>>> The assignment from these variables is only used in of_fwnode_handle()
>>> and thus they can be moved to only be used directly in the macro.
>>>
>>> Fixes: a36aa0f7226a2 ("mfd: Switch to irq_domain_create_*()")
>>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>>
>> Arnd sent a fix for this already:
>> https://lore.kernel.org/all/20250520154106.2019525-1-arnd@kernel.org/
> 
> And actually Nathan even before:
> https://lore.kernel.org/all/20250508-mfd-fix-unused-node-variables-v1-1- 
> df84d80cca55@kernel.org/

Sorry to interrupt once again. It turns out Arnd used dev_fwnode() -- my 
intention, so I actually prefer that version.

>> Hopefully all the fixes can be applied now, so no more duplicated 
>> efforts. Sorry for the breakage.

thanks,
-- 
js
suse labs


      parent reply	other threads:[~2025-06-11 10:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-02 20:09 [PATCH] mfd: Fix compilation without CONFIG_OF Mario Limonciello
2025-06-09  8:29 ` Jiri Slaby
2025-06-09  8:31   ` Jiri Slaby
2025-06-09 13:09     ` Mario Limonciello
2025-06-11 10:32     ` Jiri Slaby [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56d755fb-67d2-414a-bb49-7444a55332cb@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=aaro.koskinen@iki.fi \
    --cc=andreas@kemnade.info \
    --cc=arnd@arndb.de \
    --cc=khilman@baylibre.com \
    --cc=lee@kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=nathan@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=superm1@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.