From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2476EE6457 for ; Wed, 31 Dec 2025 16:07:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 46332840B1; Wed, 31 Dec 2025 17:07:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=mailbox.org header.i=@mailbox.org header.b="mlysE/b5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4AE45840B5; Wed, 31 Dec 2025 17:07:37 +0100 (CET) Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1817183F69 for ; Wed, 31 Dec 2025 17:07:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.vasut@mailbox.org Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4dhFGX5zy9z9spM; Wed, 31 Dec 2025 17:07:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1767197252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LMXYu9LY0yJ9Ab0AKcqNw+WDKgqaNA/o29d5lEFjiEw=; b=mlysE/b5KRvfDKtIQ/8TEei7F2vP0w8x8ltL3rmFkdsq3MK3yf5FizetgAowZRwGfcOd0R /zdXzp7AU6HgvO3sewEwRWO5DBEiYUJyjJ1VRyIsoL8KXKnauRC/unCWDoOAykUwBam+G/ gt4DwXO/zhlj4qkzVaQaqiXW0PY1VICHfOA8tbaa6oszWiB0YrzTyv0BckyT2N80YJOUfm TXoXchAmxvZygxBwZYUpvTDpuJaT5zBvmwnAzqbqkJ7afQ+6SjSsXkQsA2hnLMBxCHnIvf HsBe0XQo4xU7vLYSxYrUn4bC2zNFfY1MI58Y5wUOtKqH4nH7uOUWgLn8y/J+zg== Message-ID: <56df64f1-f3f8-4fb8-b85b-e1b1e30f5f49@mailbox.org> Date: Wed, 31 Dec 2025 17:07:31 +0100 MIME-Version: 1.0 Subject: Re: [PATCH v2 1/3] test: env: Add test for environment storage in SPI NOR To: Tom Rini Cc: Heinrich Schuchardt , Jerome Forissier , Simon Glass , u-boot@lists.denx.de References: <20251223143130.16266-1-marek.vasut+renesas@mailbox.org> <20251223233205.GG847766@bill-the-cat> Content-Language: en-US From: Marek Vasut In-Reply-To: <20251223233205.GG847766@bill-the-cat> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-MBO-RS-ID: e60aa2fc60c39417bcf X-MBO-RS-META: uw5onbier77e9i347u3n369dt17ib8r7 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 12/24/25 12:32 AM, Tom Rini wrote: > On Tue, Dec 23, 2025 at 07:55:45PM +0100, Marek Vasut wrote: >> On 12/23/25 6:32 PM, Heinrich Schuchardt wrote: >>> On 12/23/25 15:31, Marek Vasut wrote: >>>> Add test for environment stored in SPI NOR. The test works in a very >>>> similar way to the current test for environment stored in ext4 FS, >>>> except it generates spi.bin file backing the SPI NOR. >>>> >>>> Signed-off-by: Marek Vasut >>>> --- >>>> Cc: Heinrich Schuchardt >>>> Cc: Jerome Forissier >>>> Cc: Simon Glass >>>> Cc: Tom Rini >>>> Cc: u-boot@lists.denx.de >>>> --- >>>> V2: No change >>>> --- >>>>   test/py/tests/test_env.py | 99 +++++++++++++++++++++++++++++++++++++++ >>>>   1 file changed, 99 insertions(+) >>>> >>>> diff --git a/test/py/tests/test_env.py b/test/py/tests/test_env.py >>>> index 383e26c03b0..48e31f19b3c 100644 >>>> --- a/test/py/tests/test_env.py >>>> +++ b/test/py/tests/test_env.py >>>> @@ -457,6 +457,26 @@ def mk_env_ext4(state_test_env): >>>>       utils.run_and_log(c, ['cp',  '-f', persistent, fs_img]) >>>>       return fs_img >>>> +def mk_env_spi_flash(state_test_env): >>> >>> Thank you for adding the test. >>> >>> Unfortunately pylint doesn't like your code. Please have a look. >> >> Is this something we run in CI ? If so, CI builds did pass. >> >> If not, how do I trigger this ? > > We only run pylint_err not pylint in CI. The "make pylint" target has > been unused for so long that the baseline itself is out of date. I don't > object to trying to improve our python code to match standard practices > better, but this isn't the place to start adding complaints. > > All that said, a newline before a new function is just a normal good > practice and so at least the quoted here example should be fixed, just > like if it was in C :) There is a newline before the function, the code is incorrectly quoted in this discussion, see e.g. patchwork for the actual content of this patch: https://patchwork.ozlabs.org/project/uboot/patch/20251223143130.16266-1-marek.vasut+renesas@mailbox.org/ So, what exactly should be fixed in this patch ?