From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C584C54E58 for ; Wed, 20 Mar 2024 17:21:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2EAB010FE7B; Wed, 20 Mar 2024 17:21:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.b="NJ3Daoid"; dkim-atps=neutral Received: from out-187.mta0.migadu.com (out-187.mta0.migadu.com [91.218.175.187]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0A3810FE79 for ; Wed, 20 Mar 2024 17:21:11 +0000 (UTC) Message-ID: <56f8249e-9db2-435a-b370-ec5e1b28c3a4@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710955270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pm6qiQWFyDLCAlCm0+dEYC9aR0nQHy7bHYdAxJyhQvA=; b=NJ3Daoid+Uuyi+A5AejYzrTXQMHTlrZ5nGwEcR14mMcCcQmX9lhCPzZTC0j7hcLkHpcbN7 kvKQ00qnmK3jyCM1FUHEcLeRqTJUO2As2L49CK/6HqWvlH2E0saavIb0RsepsS0IcF0Lt2 JDD/xwGlAGV9X+RPTijcrbQnQfQ1VM0= Date: Thu, 21 Mar 2024 01:21:04 +0800 MIME-Version: 1.0 Subject: Re: [v5,05/13] drm/ast: Move DDC code to ast_ddc.{c,h} Content-Language: en-US To: Thomas Zimmermann , airlied@redhat.com, jfalempe@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, jani.nikula@linux.intel.com, airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org References: <20240320093738.6341-6-tzimmermann@suse.de> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: <20240320093738.6341-6-tzimmermann@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 2024/3/20 17:34, Thomas Zimmermann wrote: > Rename ast_i2c.c to ast_ddc.c and move its interface into the > new header ast_ddc.h. Update all include statements as necessary > and change the adapter name to 'AST DDC bus'. > > This avoids including I2C headers in the driver's main header file, > which doesn't need them. Renaming files to _ddc indicates that the > code is about the DDC. I2C is really just the underlying bus here. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng -- Best regards, Sui