All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Arlott <simon@fire.lp0.eu>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
	linux-mips@linux-mips.org, devicetree@vger.kernel.org,
	f.fainelli@gmail.com, jogo@openwrt.org, cernekee@gmail.com
Subject: Re: [PATCH] bmips: rename BCM63168 to BCM63268
Date: Sun, 3 Apr 2016 15:41:22 +0100	[thread overview]
Message-ID: <57012B92.6040102@simon.arlott.org.uk> (raw)
In-Reply-To: <1459684846-11308-1-git-send-email-noltari@gmail.com>

On 03/04/16 13:00, Álvaro Fernández Rojas wrote:
> BCM63168 and BCM63268 are very similar and Broadcom refers to them as BCM63268

They are practically the same but they both exist.

> diff --git a/arch/mips/bmips/setup.c b/arch/mips/bmips/setup.c
> index 38b5bd5..bfee6ea 100644
> --- a/arch/mips/bmips/setup.c
> +++ b/arch/mips/bmips/setup.c
> @@ -112,10 +112,10 @@ static void bcm6368_quirks(void)
>  static const struct bmips_quirk bmips_quirk_list[] = {
>  	{ "brcm,bcm3384-viper",		&bcm3384_viper_quirks		},
>  	{ "brcm,bcm33843-viper",	&bcm3384_viper_quirks		},
> +	{ "brcm,bcm63268",		&bcm6368_quirks			},
>  	{ "brcm,bcm6328",		&bcm6328_quirks			},
>  	{ "brcm,bcm6358",		&bcm6358_quirks			},
>  	{ "brcm,bcm6368",		&bcm6368_quirks			},
> -	{ "brcm,bcm63168",		&bcm6368_quirks			},

You can add "brcm,bcm63268" but you can't remove support for
"brcm,bcm63168".

>  	{ },
>  };
>  
> 

-- 
Simon Arlott

  reply	other threads:[~2016-04-03 14:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-03 12:00 [PATCH] bmips: rename BCM63168 to BCM63268 Álvaro Fernández Rojas
2016-04-03 12:00 ` Álvaro Fernández Rojas
2016-04-03 14:41 ` Simon Arlott [this message]
2016-04-03 18:31   ` Florian Fainelli
2016-04-03 18:31     ` Florian Fainelli
2016-04-04  8:11 ` [PATCH v2] bmips: add support for BCM63268 Álvaro Fernández Rojas
2016-04-07 17:57   ` Rob Herring
2016-04-07 17:57     ` Rob Herring
2016-04-09 10:57   ` [PATCH] " Álvaro Fernández Rojas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57012B92.6040102@simon.arlott.org.uk \
    --to=simon@fire.lp0.eu \
    --cc=cernekee@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=jogo@openwrt.org \
    --cc=linux-mips@linux-mips.org \
    --cc=noltari@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.