From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [RFC 0/6] drm/fences: add in-fences to DRM Date: Mon, 04 Apr 2016 09:14:12 +0900 Message-ID: <5701B1D4.3010505@samsung.com> References: <1458758847-21170-1-git-send-email-gustavo@padovan.org> <56F3A2DC.8080507@samsung.com> <56F47D01.7040508@samsung.com> <56F88828.5050304@samsung.com> <56F9E613.1030902@samsung.com> <56FCD5A3.4040700@samsung.com> <56FCF67A.8090109@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3434F6E101 for ; Mon, 4 Apr 2016 00:14:16 +0000 (UTC) Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O5302RZS1ZOLQ30@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 04 Apr 2016 09:14:12 +0900 (KST) In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark , Inki Dae Cc: Daniel Vetter , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOl?= =?UTF-8?B?Zw==?= , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List , Riley Andrews , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org CjIwMTbrhYQgMDPsm5QgMzHsnbwgMjM6MTDsl5AgUm9iIENsYXJrIOydtCjqsIApIOyTtCDquIA6 Cj4gT24gVGh1LCBNYXIgMzEsIDIwMTYgYXQgNzoyNiBBTSwgSW5raSBEYWUgPGRhZWlua2lAZ21h aWwuY29tPiB3cm90ZToKPj4gSGkgRGFuaWVsLAo+Pgo+PiAyMDE2LTAzLTMxIDE5OjU2IEdNVCsw OTowMCBEYW5pZWwgU3RvbmUgPGRhbmllbEBmb29pc2hiYXIub3JnPjoKPj4+IEhpIElua2ksCj4+ Pgo+Pj4gT24gMzEgTWFyY2ggMjAxNiBhdCAxMTowNSwgSW5raSBEYWUgPGlua2kuZGFlQHNhbXN1 bmcuY29tPiB3cm90ZToKPj4+PiAyMDE264WEIDAz7JuUIDMx7J28IDE4OjM17JeQIERhbmllbCBT dG9uZSDsnbQo6rCAKSDsk7Qg6riAOgo+Pj4+PiBPbiAzMSBNYXJjaCAyMDE2IGF0IDA4OjQ1LCBJ bmtpIERhZSA8aW5raS5kYWVAc2Ftc3VuZy5jb20+IHdyb3RlOgo+Pj4+Pj4gQXMgb2Ygbm93LCBp dCBzZWVtcyB0aGF0IHRoaXMgd291bGRuJ3QgYmUgb3B0aW9uYWwgYnV0IG1hbmRhdG9yeSBpZiBl eHBsaWNpdCBmZW5jZSBzdXBwb3J0IGlzIGFkZGVkIHRvIHRoZSBhdG9taWMgaGVscGVyIGZyYW1l d29yay4gVGhpcyB3b3VsZCBkZWZpbml0ZWx5IGJlIGR1cGxpY2F0aW9uIGFuZCBpdCBzZWVtcyBu b3QgY2xlYXIgZW5vdWdoIGV2ZW4gaWYgb25lIG9mIHRoZW0gaXMganVzdCBza2lwcGVkIGluIHJ1 bnRpbWUuCj4+Pj4+Cj4+Pj4+IERyaXZlcnMgd291bGQgaGF2ZSB0byBvcHQgaW4gdG8gZXhwbGlj aXQgZmVuY2luZyBzdXBwb3J0LCBhbmQgcGFydCBvZgo+Pj4+PiB0aGF0IHdvdWxkIGJlIGVuc3Vy aW5nIHRoYXQgdGhlIGRyaXZlciBkb2VzIG5vdCB3YWl0IG9uIGltcGxpY2l0Cj4+Pj4+IGZlbmNl cyB3aGVuIHRoZSB1c2VyIGhhcyByZXF1ZXN0ZWQgZXhwbGljaXQgZmVuY2luZyBiZSB1c2VkLgo+ Pj4+Pgo+Pj4+Cj4+Pj4gVGhlbiwgZXhpc3RpbmcgZHJpdmVycyB3b3VsZCBuZWVkIGFkZGl0aW9u YWwgd29ya3MgZm9yIGV4cGxpY2l0IGZlbmNpbmcgc3VwcG9ydC4gVGhpcyB3b3VsZG4ndCBiZSBy ZWFsbHkgd2hhdCB0aGUgZHJpdmVycyBoYXZlIHRvIGJ1dCBzaG91bGQgYmUgaGFuZGxlZCB3aXRo IHRoaXMgcGF0Y2ggc2VyaWVzIGJlY2F1c2UgdGhpcyB3b3VsZCBhZmZlY3QgZXhpc2luZyBkZXZp Y2UgZHJpdmVycyB3aGljaCB1c2UgaW1wbGljaXQgZmVuY2luZy4KPj4+Cj4+PiBXZWxsLCB5ZXMu IEFueW9uZSBpbXBsZW1lbnRpbmcgdGhlaXIgb3duIGF0b21pYyBjb21taXQgd291bGQgbmVlZCB0 bwo+Pj4gZW5zdXJlIHRoYXQgdGhlIGNvbW1pdCB3b3JrcyBwcm9wZXJseSBmb3IgZmVuY2VzLiBU aGUgaGVscGVycyBjb3VsZAo+Pj4gYWxzbyBhZGQgaXQsIGJ1dCB0aGUgaGVscGVycyBhcmUgbm90 IG1hbmRhdG9yeSwgYW5kIHlvdSBhcmUgbm90Cj4+PiByZXF1aXJlZCB0byB1c2UgZXZlcnkgcGFy dCBvZiB0aGUgaGVscGVyIHRvIHVzZSBvbmUgcGFydCBvZiB0aGUKPj4+IGhlbHBlci4gVGhlcmUg aXMgbm8gbWFnaWMgd2FuZCB5b3UgY2FuIHdhdmUgdGhhdCBpbnN0YW50bHkgbWFrZXMgaXQKPj4+ IHdvcmsgZm9yIGV2ZXJ5IGRyaXZlcgo+Pgo+PiBJIG1lYW50IHRoZXJlIGFyZSBhbHJlYWR5IHNl dmVyYWwgRFJNIGRyaXZlcnMgd2hpY2ggd29yayBwcm9wZXJseSBmb3IKPj4gaW1wbGljaXQgZmVu Y2UuIFNvIGlmIGF0b21pYyBoZWxwZXIgZnJhbWV3b3JrIG9mIERSTSBjb3JlIGlzCj4+IGNvbnNp ZGVyZWQgb25seSBmb3IgdGhlIGV4cGxpY2l0IGZlbmNlLCB0aGVuIGZlbmNpbmcgb3BlcmF0aW9u IHdvdWxkCj4+IGFmZmVjdCB0aGUgZXhpc3RpbmcgRFJNIGRyaXZlcnMuIFNvIEkgaG9wZSB0aGlz IHRyeWluZyBjb3VsZCBjb25zaWRlcgo+PiBleGlzdGluZyBpbXBsaWNpdCBmZW5jZSB1c2Vycy4K Pj4KPiAKPiBOb3RlIHRoYXQgdGhlcmUgd291bGQgYmUgYSBuZXcgZmxhZyBvbiB0aGUgYXRvbWlj IGlvY3RsIHRvIHJlcXVlc3QKCldoYXQgaXMgdGhlIG5ldyBmbGFnPyBBbmQgV2hlcmUgSSBjb3Vs ZCBmaW5kIHRoZSBuZXcgZmxhZz8KCj4gZXhwbGljaXQgZmVuY2luZywgYW5kIHdpdGggYW4gb2xk IGtlcm5lbCBvciBhIGRyaXZlciB0aGF0IGRvZXMgbm90Cj4gc3VwcG9ydCBpdCwgdGhlIGlvY3Rs IHdvdWxkIGJlIHJlamVjdGVkIGFuZCBhbiBlcnJvciByZXR1cm5lZC4gIFRoZQo+IGF0b21pYy9r bXMgZnJhbWV3b3JrIHdvdWxkIG9mIGNvdXJzZSBjb250aW51ZSB0byBzdXBwb3J0IGltcGxpY2l0 CgpJIGNvdWxkbid0IGZpbmQgd2hlcmUgc3VjaCBleGNlcHRpb25zIGFyZSBjb25zaWRlcmVkLgpB bmQgYXMgb2Ygbm93LCBJIHRoaW5rIGltcGxpY2l0IGZlbmNlIGlzIGltcGxlbWVudGVkIGJ5IGRy aXZlcnMgc28gaGlkZWQgZnJvbSBkcm0gY29yZSBmcmFtZXdvcmsuIFNvIGhvdyBhdG9taWMva21z IGZyYW1ld29yayBrbm93cyB3aGV0aGVyIGV4cGxpY2l0IG9yIGltcGxpY2l0IGZlbmNlIGlzIHN1 cHBvcnRlZCBieSBkcml2ZXI/Ck90aGVyd2lzZSwgeW91IG1lYW4gc3VjaCB0aGluZ3MgYXJlIFRP RE8gaW4gdGhlIGZ1dHVyZT8KClRoZXJlIG1heSBiZSBzb21lIGxvZ2ljIEkgZG9uJ3QgdW5kZXJz dGFuZCB5ZXQuCgpUaGFua3MsCklua2kgRGFlCgo+IGZlbmNpbmcuICAgQW5kIGFuIGV4cGxpY2l0 LWZlbmNpbmcgdXNlcnNwYWNlIHdvdWxkIHJlcXVpcmUgYQo+IHN1ZmZpY2llbnRseSBuZXcga2Vy bmVsIGFuZCBwb3NzaWJseSBzb21lIG1pbm9yIGRyaXZlciBzdXBwb3J0IChhYm92ZQo+IGFuZCBi ZXlvbmQgJ3N0cnVjdCBmZW5jZScgY29udmVyc2lvbikuCj4gCj4gQlIsCj4gLVIKPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWls aW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPiAKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753384AbcDDAOR (ORCPT ); Sun, 3 Apr 2016 20:14:17 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:46948 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752454AbcDDAOP (ORCPT ); Sun, 3 Apr 2016 20:14:15 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68d-f79e86d0000012da-c7-5701b1d4a13f Content-transfer-encoding: 8BIT Message-id: <5701B1D4.3010505@samsung.com> Date: Mon, 04 Apr 2016 09:14:12 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Rob Clark , Inki Dae Cc: Daniel Vetter , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOl?= =?UTF-8?B?Zw==?= , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List , Riley Andrews , Gustavo Padovan , John Harrison Subject: Re: [RFC 0/6] drm/fences: add in-fences to DRM References: <1458758847-21170-1-git-send-email-gustavo@padovan.org> <56F3A2DC.8080507@samsung.com> <56F47D01.7040508@samsung.com> <56F88828.5050304@samsung.com> <56F9E613.1030902@samsung.com> <56FCD5A3.4040700@samsung.com> <56FCF67A.8090109@samsung.com> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMIsWRmVeSWpSXmKPExsWyRsSkUPfKRsZwg23XzSze/73PZvG06yKz xcKHd5ktrnx9z2bxaXUru8Wkpw/YLC7vmsNm8XrTX0aL5wt/MDtwemzbvY3V4+/z6ywee78t YPHYOesuu8fiPS+ZPO53H2fy+LxJLoA9issmJTUnsyy1SN8ugStjV982xoLj4hWLJ91kb2Cc INzFyMkhIWAi8bThAQuELSZx4d56ti5GLg4hgRWMEi1L7jLCFB3YtpUVxBYSmMUoMWmnLIjN KyAo8WPyPaBmDg5mAXmJI5eyIUx1iSlTciHGPGCU+LThAjNEuZZE59ouMJtFQFXix8szYCPZ gOyJK+6zgfSKCkRIdJ+oBAmLCDhKzDl5lR3EZhZoYJb4fUoDxBYWMJfofdjJCjG/g11i7/9u sPs5BYIltiyYyA6SkBD4yC4x48VERohlAhLfJh8Cu1NCQFZi0wFmiLckJQ6uuMEygVFsFpJv ZiF8MwvhmwWMzKsYRVMLkguKk9KLDPWKE3OLS/PS9ZLzczcxAuPy9L9nvTsYbx+wPsQowMGo xMP7wp0hXIg1say4MvcQoynQDROZpUST84HRn1cSb2hsZmRhamJqbGRuaaYkzqso9TNYSCA9 sSQ1OzW1ILUovqg0J7X4ECMTB6dUA+OlTLVjqlMmTEtev/TL/UkHdwTuVQ76oblahbE80lt+ /lKO1xO/VMRq/T9hlpgmnyh/UMYyzOnbBBOzO86F3zWymGybbKVO3xGPVi6xZf2UJH2P4dmC S771m6X8D796sdNfs25xtF3PhqTeim/NV2sf6gUYpfzY3NdxfXGrtvG+ieoOy1/wr1FiKc5I NNRiLipOBAB8ApxcxgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgleLIzCtJLcpLzFFi42I5/e+xoO6VjYzhBmdbDC3e/73PZvG06yKz xcKHd5ktrnx9z2bxaXUru8Wkpw/YLC7vmsNm8XrTX0aL5wt/MDtwemzbvY3V4+/z6ywee78t YPHYOesuu8fiPS+ZPO53H2fy+LxJLoA9qoHRJiM1MSW1SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ 19DSwlxJIS8xN9VWycUnQNctMwfoNiWFssScUqBQQGJxsZK+HaYJoSFuuhYwjRG6viFBcD1G BmggYQ1jxq6+bYwFx8UrFk+6yd7AOEG4i5GTQ0LAROLAtq2sELaYxIV769lAbCGBWYwSk3bK gti8AoISPybfY+li5OBgFpCXOHIpG8JUl5gyJbeLkQuo+gGjxKcNF5ghyrUkOtd2gdksAqoS P16eARvPBmRPXHGfDaRXVCBCovtEJUhYRMBRYs7Jq+wgNrNAA7PE71MaILawgLlE78NOVoj5 HewSe/93s4AkOAWCJbYsmMg+gRHoRoTrZiFcNwvhugWMzKsYJVILkguKk9JzjfJSy/WKE3OL S/PS9ZLzczcxgmP/mfQOxsO73A8xCnAwKvHwTnBlCBdiTSwrrsw9xCjBwawkwsu1ijFciDcl sbIqtSg/vqg0J7X4EKMp0HsTmaVEk/OBaSmvJN7Q2MTMyNLI3NDCyNhcSZz38f91YUIC6Ykl qdmpqQWpRTB9TBycUg2M0hnMArU8m1Kuin5W/FJ8/+DdZS+9j+mvVJvySGQ/cxqbZkbdxFd7 2597TVjVFfmT5e4tQ+5cnfUFNd9lXZomu215pNa79ljI6tJ9Rn5trZU3dvf+Wfar8IaOnhO/ S1rVzi3n8pdOMLsyJfD921t8K5nmLpybzSQjtSp40oyWNyuUJk3hnhK4QImlOCPRUIu5qDgR ADHDHd4TAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016년 03월 31일 23:10에 Rob Clark 이(가) 쓴 글: > On Thu, Mar 31, 2016 at 7:26 AM, Inki Dae wrote: >> Hi Daniel, >> >> 2016-03-31 19:56 GMT+09:00 Daniel Stone : >>> Hi Inki, >>> >>> On 31 March 2016 at 11:05, Inki Dae wrote: >>>> 2016년 03월 31일 18:35에 Daniel Stone 이(가) 쓴 글: >>>>> On 31 March 2016 at 08:45, Inki Dae wrote: >>>>>> As of now, it seems that this wouldn't be optional but mandatory if explicit fence support is added to the atomic helper framework. This would definitely be duplication and it seems not clear enough even if one of them is just skipped in runtime. >>>>> >>>>> Drivers would have to opt in to explicit fencing support, and part of >>>>> that would be ensuring that the driver does not wait on implicit >>>>> fences when the user has requested explicit fencing be used. >>>>> >>>> >>>> Then, existing drivers would need additional works for explicit fencing support. This wouldn't be really what the drivers have to but should be handled with this patch series because this would affect exising device drivers which use implicit fencing. >>> >>> Well, yes. Anyone implementing their own atomic commit would need to >>> ensure that the commit works properly for fences. The helpers could >>> also add it, but the helpers are not mandatory, and you are not >>> required to use every part of the helper to use one part of the >>> helper. There is no magic wand you can wave that instantly makes it >>> work for every driver >> >> I meant there are already several DRM drivers which work properly for >> implicit fence. So if atomic helper framework of DRM core is >> considered only for the explicit fence, then fencing operation would >> affect the existing DRM drivers. So I hope this trying could consider >> existing implicit fence users. >> > > Note that there would be a new flag on the atomic ioctl to request What is the new flag? And Where I could find the new flag? > explicit fencing, and with an old kernel or a driver that does not > support it, the ioctl would be rejected and an error returned. The > atomic/kms framework would of course continue to support implicit I couldn't find where such exceptions are considered. And as of now, I think implicit fence is implemented by drivers so hided from drm core framework. So how atomic/kms framework knows whether explicit or implicit fence is supported by driver? Otherwise, you mean such things are TODO in the future? There may be some logic I don't understand yet. Thanks, Inki Dae > fencing. And an explicit-fencing userspace would require a > sufficiently new kernel and possibly some minor driver support (above > and beyond 'struct fence' conversion). > > BR, > -R > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel >