From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH V2] extcon: palmas: Drop stray IRQF_EARLY_RESUME flag Date: Mon, 04 Apr 2016 09:58:34 +0900 Message-ID: <5701BC3A.5070606@samsung.com> References: <1459518767-20382-1-git-send-email-nm@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <1459518767-20382-1-git-send-email-nm@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Nishanth Menon , MyungJoo Ham Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Grygorii Strashko , Tony Lindgren , Lee Jones , Roger Quadros List-Id: linux-omap@vger.kernel.org On 2016=EB=85=84 04=EC=9B=94 01=EC=9D=BC 22:52, Nishanth Menon wrote: > Palmas extcon IRQs are nested threaded and wired to the Palmas > interrupt controller. So, this flag is not required for nested > IRQs anymore, since commit 3c646f2c6aa9 ("genirq: Don't suspend > nested_thread irqs over system suspend") was merged. However, the > fix in commit ae64e42cc2b3 ("extcon: palmas: Drop IRQF_EARLY_RESUME > flag") missed a stray flag causing the following crash on resume on > BeagleBoard-X15 platform: >=20 > [ 53.670141] Unhandled fault: imprecise external abort (0x1406) at = 0x00000000 > [..] > [ 53.670141] [] (omap_set_gpio_triggering) from [] (omap_gpio_unmask_irq+0xc0/0xc4) > [ 53.670141] [] (omap_gpio_unmask_irq) from [] = (irq_enable+0x30/0x44) > [ 53.670141] [] (irq_enable) from [] (__enable_= irq+0x54/0x78) > [ 53.670141] [] (__enable_irq) from [] (resume_= irqs+0xe8/0x100) > [ 53.670141] [] (resume_irqs) from [] (syscore_= resume+0x94/0x298) > [ 53.670141] [] (syscore_resume) from [] (suspe= nd_devices_and_enter+0x790/0x9e4) > [ 53.670141] [] (suspend_devices_and_enter) from [] (pm_suspend+0x640/0x75c) > [ 53.670141] [] (pm_suspend) from [] (state_sto= re+0x64/0xb8) > [ 53.670141] [] (state_store) from [] (kernfs_f= op_write+0xc0/0x1bc) > [ 53.670141] [] (kernfs_fop_write) from [] (__v= fs_write+0x1c/0xd8) > [ 53.670141] [] (__vfs_write) from [] (vfs_writ= e+0x90/0x16c) > [ 53.670141] [] (vfs_write) from [] (SyS_write+= 0x44/0x9c) > [ 53.670141] [] (SyS_write) from [] (ret_fast_s= yscall+0x0/0x1c) > [..] >=20 > Fixes: ae64e42cc2b3 ("extcon: palmas: Drop IRQF_EARLY_RESUME flag") > Cc: Grygorii Strashko > Cc: MyungJoo Ham > Cc: Chanwoo Choi > Cc: Tony Lindgren > Cc: Lee Jones > Cc: Roger Quadros >=20 > Reviewed-by: Grygorii Strashko > Signed-off-by: Nishanth Menon Applied it. Thanks, Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Mon, 04 Apr 2016 09:58:34 +0900 Subject: [PATCH V2] extcon: palmas: Drop stray IRQF_EARLY_RESUME flag In-Reply-To: <1459518767-20382-1-git-send-email-nm@ti.com> References: <1459518767-20382-1-git-send-email-nm@ti.com> Message-ID: <5701BC3A.5070606@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016? 04? 01? 22:52, Nishanth Menon wrote: > Palmas extcon IRQs are nested threaded and wired to the Palmas > interrupt controller. So, this flag is not required for nested > IRQs anymore, since commit 3c646f2c6aa9 ("genirq: Don't suspend > nested_thread irqs over system suspend") was merged. However, the > fix in commit ae64e42cc2b3 ("extcon: palmas: Drop IRQF_EARLY_RESUME > flag") missed a stray flag causing the following crash on resume on > BeagleBoard-X15 platform: > > [ 53.670141] Unhandled fault: imprecise external abort (0x1406) at 0x00000000 > [..] > [ 53.670141] [] (omap_set_gpio_triggering) from [] (omap_gpio_unmask_irq+0xc0/0xc4) > [ 53.670141] [] (omap_gpio_unmask_irq) from [] (irq_enable+0x30/0x44) > [ 53.670141] [] (irq_enable) from [] (__enable_irq+0x54/0x78) > [ 53.670141] [] (__enable_irq) from [] (resume_irqs+0xe8/0x100) > [ 53.670141] [] (resume_irqs) from [] (syscore_resume+0x94/0x298) > [ 53.670141] [] (syscore_resume) from [] (suspend_devices_and_enter+0x790/0x9e4) > [ 53.670141] [] (suspend_devices_and_enter) from [] (pm_suspend+0x640/0x75c) > [ 53.670141] [] (pm_suspend) from [] (state_store+0x64/0xb8) > [ 53.670141] [] (state_store) from [] (kernfs_fop_write+0xc0/0x1bc) > [ 53.670141] [] (kernfs_fop_write) from [] (__vfs_write+0x1c/0xd8) > [ 53.670141] [] (__vfs_write) from [] (vfs_write+0x90/0x16c) > [ 53.670141] [] (vfs_write) from [] (SyS_write+0x44/0x9c) > [ 53.670141] [] (SyS_write) from [] (ret_fast_syscall+0x0/0x1c) > [..] > > Fixes: ae64e42cc2b3 ("extcon: palmas: Drop IRQF_EARLY_RESUME flag") > Cc: Grygorii Strashko > Cc: MyungJoo Ham > Cc: Chanwoo Choi > Cc: Tony Lindgren > Cc: Lee Jones > Cc: Roger Quadros > > Reviewed-by: Grygorii Strashko > Signed-off-by: Nishanth Menon Applied it. Thanks, Chanwoo Choi