From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amzjm-0003xC-7E for qemu-devel@nongnu.org; Mon, 04 Apr 2016 04:19:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amzjl-0001gt-Dc for qemu-devel@nongnu.org; Mon, 04 Apr 2016 04:19:54 -0400 References: <1459679740-17519-1-git-send-email-mst@redhat.com> <57017629.9090108@de.ibm.com> <57018778.8060408@redhat.com> <20160404101013.4dec0db2.cornelia.huck@de.ibm.com> From: Paolo Bonzini Message-ID: <5702239E.5070407@redhat.com> Date: Mon, 4 Apr 2016 10:19:42 +0200 MIME-Version: 1.0 In-Reply-To: <20160404101013.4dec0db2.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-blk: assert on starting/stopping List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Kevin Wolf , qemu-block@nongnu.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Christian Borntraeger , Stefan Hajnoczi On 04/04/2016 10:10, Cornelia Huck wrote: > > This will be fixed by Cornelia's rework, and is an example of why I > > think patch 1/9 is a good idea (IOW, assign=false is harmful). > > So what do we want to do for 2.6? The aio handler rework (without the > cleanup) is needed. Do we want to include the minimal version of my > "keep handler assigned" patch (the one without the api rework) as well, > as it fixes a latent bug? I would, but Michael is more conservative in general. Since the difference between a bug and a feature is very fuzzy here, I would just omit my patch 9. Paolo