From: Markus Reichl <m.reichl@fivetechno.de>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: exynos-5422-odroid: Add eMMC and SD regulator supplies
Date: Mon, 4 Apr 2016 10:35:18 +0200 [thread overview]
Message-ID: <57022746.6050700@fivetechno.de> (raw)
In-Reply-To: <5701B53B.8000703@samsung.com>
Hi Krzysztof,
Am 04.04.2016 um 02:28 schrieb Krzysztof Kozlowski:
> On 01.04.2016 22:42, Markus Reichl wrote:
>> Add vmmc and vqmmc supplies from MF circuit sheets for eMMC and SD on
>> odroid XU3 and XU4 to avoid warnings in dmesg output.
>
> What warnings?
[ 1.843689] dwmmc_exynos 12200000.mmc: Looking up vmmc-supply property in node /mmc@12200000 failed
[ 1.843773] dwmmc_exynos 12200000.mmc: Looking up vqmmc-supply property in node /mmc@12200000 failed
[ 1.912340] dwmmc_exynos 12220000.mmc: Looking up vmmc-supply property in node /mmc@12220000 failed
[ 1.912410] dwmmc_exynos 12220000.mmc: Looking up vqmmc-supply property in node /mmc@12220000 failed
>
>>
>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>> ---
>> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 15 +++++++++++++--
>> 1 file changed, 13 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> index 1bd507b..eec425a 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> @@ -121,7 +121,7 @@
>> };
>>
>> ldo3_reg: LDO3 {
>> - regulator-name = "vdd_ldo3";
>> + regulator-name = "vddq_mmc0";
>> regulator-min-microvolt = <1800000>;
>> regulator-max-microvolt = <1800000>;
>> regulator-always-on;
>> @@ -184,7 +184,7 @@
>> };
>>
>> ldo13_reg: LDO13 {
>> - regulator-name = "vdd_ldo13";
>> + regulator-name = "vddq_mmc2";
>> regulator-min-microvolt = <2800000>;
>> regulator-max-microvolt = <2800000>;
>> regulator-always-on;
>> @@ -211,6 +211,13 @@
>> regulator-always-on;
>> };
>>
>> + ldo18_reg: LDO18 {
>> + regulator-name = "vdd_emmc_1V8";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <1800000>;
>> + regulator-always-on;
>
> In the same patchset you add always-on and remove. What is the point of
> this juggle?
I will squash the two patches together in one.
>
> Best regards,
> Krzysztof
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Servus,
--
Markus Reichl
prev parent reply other threads:[~2016-04-04 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 13:42 [PATCH] ARM: dts: exynos-5422-odroid: Add eMMC and SD regulator supplies Markus Reichl
2016-04-04 0:28 ` Krzysztof Kozlowski
2016-04-04 8:35 ` Markus Reichl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57022746.6050700@fivetechno.de \
--to=m.reichl@fivetechno.de \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.