Re: [PATCH i-g-t 4/5] tests: fix spelling mistakes

[Dave Gordon <david.s.gordon@intel.com>]

On 03/04/16 17:35, Eric Engestrom wrote:
> Signed-off-by: Eric Engestrom <eric@engestrom.ch>
> ---
>   tests/gem_concurrent_all.c | 2 +-
>   tests/gem_cpu_reloc.c      | 2 +-
>   tests/gem_flink_race.c     | 2 +-
>   tests/gem_seqno_wrap.c     | 2 +-
>   tests/gem_tiled_wb.c       | 2 +-
>   tests/prime_nv_api.c       | 2 +-
>   tests/prime_nv_pcopy.c     | 2 +-
>   tests/prime_self_import.c  | 4 ++--
>   8 files changed, 9 insertions(+), 9 deletions(-)

[snip]

> diff --git a/tests/prime_nv_api.c b/tests/prime_nv_api.c
> index 054a1ec..6bf891a 100644
> --- a/tests/prime_nv_api.c
> +++ b/tests/prime_nv_api.c
> @@ -1,4 +1,4 @@
> -/* wierd use of API tests */
> +/* weird use of API tests */
>
>   /* test1- export buffer from intel, import same fd twice into nouveau,
>      check handles match
> diff --git a/tests/prime_nv_pcopy.c b/tests/prime_nv_pcopy.c
> index b5ceabf..99eaeea 100644
> --- a/tests/prime_nv_pcopy.c
> +++ b/tests/prime_nv_pcopy.c
> @@ -673,7 +673,7 @@ static void check3(const uint32_t *p, uint32_t pitch, uint32_t lines,
>   	}
>   }
>
> -/* copy from nvidia bo to intel bo and copy to a linear bo to check if tiling went succesful */
> +/* copy from nvidia bo to intel bo and copy to a linear bo to check if tiling went successful */

Might as well correct the grammar here too - I'd suggest "was 
successful", or else "went successfully", but the latter still seems 
rather clumsy.

Apart from that, they all look good, so

Reviewed-by: Dave Gordon <david.s.gordon@intel.com>

IIRC there's a tool ("codespell"?) that can help find these typos; 
perhaps it would be worth adding the most recurrent of them (e,g, 
intruction->instruction) to the dictionary?

.Dave.

PS: Found the tool: https://github.com/lucasdemarchi/codespell
     Dictionary is /usr/share/codespell/dictionary.txt

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx