Re: [Qemu-devel] [V8 4/4] hw/pci-host: Emulate AMD IOMMU

[Marcel Apfelbaum <marcel.apfelbaum@gmail.com>]

On 04/01/2016 09:39 PM, David Kiarie wrote:
> Add AMD IOMMU emulation support to q35 chipset
>
> Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
> ---
>   hw/pci-host/q35.c             | 21 +++++++++++++++++++--
>   include/hw/i386/intel_iommu.h |  1 +
>   2 files changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
> index 70f897e..37f8a84 100644
> --- a/hw/pci-host/q35.c
> +++ b/hw/pci-host/q35.c
> @@ -32,6 +32,7 @@
>   #include "hw/pci-host/q35.h"
>   #include "qapi/error.h"
>   #include "qapi/visitor.h"
> +#include "hw/i386/amd_iommu.h"
>
>   /****************************************************************************
>    * Q35 host
> @@ -448,6 +449,19 @@ static void mch_init_dmar(MCHPCIState *mch)
>       pci_setup_iommu(pci_bus, q35_host_dma_iommu, mch->iommu);
>   }
>
> +static void mch_init_amdvi(MCHPCIState *mch)
> +{
> +    AMDIOMMUState *iommu_state;
> +    PCIBus *bus = PCI_BUS(qdev_get_parent_bus(DEVICE(mch)));
> +    PCIDevice *iommu;
> +
> +    iommu = pci_create_simple(bus, 0x20, TYPE_AMD_IOMMU_DEVICE);
> +
> +    iommu_state = AMD_IOMMU_DEVICE(iommu);
> +
> +    pci_setup_iommu(bus, bridge_host_amd_iommu, iommu_state);
> +}
> +
>   static void mch_realize(PCIDevice *d, Error **errp)
>   {
>       int i;
> @@ -506,8 +520,11 @@ static void mch_realize(PCIDevice *d, Error **errp)
>                    mch->pci_address_space, &mch->pam_regions[i+1],
>                    PAM_EXPAN_BASE + i * PAM_EXPAN_SIZE, PAM_EXPAN_SIZE);
>       }
> -    /* Intel IOMMU (VT-d) */
> -    if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) {
> +
> +    if (object_property_get_bool(qdev_get_machine(), "iommu", NULL) &&
> +        MACHINE(qdev_get_machine())->x_iommu_type) {

Here you don't need to check twice the iommu property, and even use the long object_property_get_bool.

You can use something like :

   machine = MACHINE(qdev_get_machine());
   if (machine->iommu) {
     if (machine->amd_iommu) {  /* or use a switch if you opt for enum */
       ...
     } else { /* intel */
       ...
     }
  }

Other than that the patch is ready.

Thanks,
Marcel

> +        mch_init_amdvi(mch);
> +    } else if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) {
>           mch_init_dmar(mch);
>       }
>   }
> diff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h
> index 7e511e1..5a520f3 100644
> --- a/include/hw/i386/intel_iommu.h
> +++ b/include/hw/i386/intel_iommu.h
> @@ -28,6 +28,7 @@
>   #define TYPE_INTEL_IOMMU_DEVICE "intel-iommu"
>   #define INTEL_IOMMU_DEVICE(obj) \
>        OBJECT_CHECK(IntelIOMMUState, (obj), TYPE_INTEL_IOMMU_DEVICE)
> +#define INTEL_IOMMU_STR "intel"
>
>   /* DMAR Hardware Unit Definition address (IOMMU unit) */
>   #define Q35_HOST_BRIDGE_IOMMU_ADDR  0xfed90000ULL
>