From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: MTTCG Devel <mttcg@greensocs.com>,
Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Cota@braap.org, Sergey Fedorov <serge.fdrv@gmail.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] Should we introduce a TranslationRegion with its own codegen buffer?
Date: Mon, 4 Apr 2016 14:13:18 +0200 [thread overview]
Message-ID: <57025A5E.3020008@redhat.com> (raw)
In-Reply-To: <87vb3xtwg1.fsf@linaro.org>
On 04/04/2016 14:01, Alex Bennée wrote:
> > > - is pretty ugly anyway
> >
> > What exactly makes it ugly?
>
> Subjective I guess but the use of tb_lock_recursive() and
> tb_lock_reset() seem not as clean as they could be. Is this stuff Fred
> re-introduced?
I think tb_lock_recursive is mine, while tb_lock_reset is from Fred.
I concede that those functions are a bit ugly, but that is unrelated to
the "tb_find_fast outside tb_lock" idea (which was from Fred and gives a
~20% or so speedup at -smp 2; more as the number of VCPUs increases).
You could make tb_lock recursive I guess if you want to avoid
tb_lock_recursive() but it really just sweeps it under the carpet.
tb_lock_reset() is needed anyway because it is used after longjmp.
Paolo
prev parent reply other threads:[~2016-04-04 12:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 8:54 [Qemu-devel] Should we introduce a TranslationRegion with its own codegen buffer? Alex Bennée
2016-04-04 9:01 ` Paolo Bonzini
2016-04-04 10:39 ` Sergey Fedorov
2016-04-04 11:24 ` Alex Bennée
2016-04-04 11:33 ` Paolo Bonzini
2016-04-04 12:01 ` Alex Bennée
2016-04-04 12:13 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57025A5E.3020008@redhat.com \
--to=pbonzini@redhat.com \
--cc=Cota@braap.org \
--cc=alex.bennee@linaro.org \
--cc=mttcg@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=serge.fdrv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.