From: Julien Grall <julien.grall@arm.com>
To: Wei Liu <wei.liu2@citrix.com>,
Benjamin Sanda <ben.sanda@dornerworks.com>
Cc: sstabellini@kernel.org, Keir Fraser <keir@xen.org>,
George Dunlap <george.dunlap@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH V2 0/9] xentrace/xenalyze support on ARM
Date: Mon, 4 Apr 2016 16:02:20 +0100 [thread overview]
Message-ID: <570281FC.3070203@arm.com> (raw)
In-Reply-To: <20160404141107.GK25710@citrix.com>
Hello,
On 04/04/2016 15:11, Wei Liu wrote:
> On Fri, Apr 01, 2016 at 04:33:44PM -0400, Benjamin Sanda wrote:
>> ---
>> Changed since v1:
>> * Removed Flask changes as deemed uncessesary and unclear in
>> purpose
>> * Corrected all commit messages to be line limited to 72 chars
>> * Implimented v1 review comments as indicated in each file's
>> commit log.
>>
>> Benjamin Sanda (9):
>> xenalyze: Support for ARM platform
>> xentrace: Support for ARM platform
>> xentrace: Support for ARM platform
>> xentrace: Support for ARM platform
>> xentrace: Support for ARM platform
>> xentrace: Support for ARM platform
>> xentrace: Support for ARM platform
>> xentrace: Support for ARM platform
>> xentrace: Support for ARM platform
>
> You patches all have the same subject line. Please make them more
> specific. See my reply to #1 for example.
+1
Also, you should at least check that Xen still builds after applying
each patch. Ideally, you also need to be careful to not break any
feature currently supported. It's useful when someone needs to bisect
the tree.
For instance, you use the function get_pg_owner for ARM in patch #2 but
introduce the function in patch #4. This will break ARM build. So the
patch #2 should be moved after #4.
Furthermore, you remove the functions get_pg_owner and put_pg_owner for
x86 in patch #3 and then re-introduced them in patch #4. Therefore, the
x86 will be broken after #3. In this case, it's better to have a patch
that move the 2 functions from x86 to common.
Finally, please CC all the x86 maintainers (Jan and Andrew) on x86
changes. You need to manually check the CCs as under certain conditions
the script get_maintainers.pl may not return all the relevant maintainers.
I will wait the next iteration of this series to review the code.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-04 15:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 20:33 [PATCH V2 0/9] xentrace/xenalyze support on ARM Benjamin Sanda
2016-04-01 20:33 ` Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 1/9] xenalyze: Support for ARM platform Benjamin Sanda
2016-04-04 14:10 ` Wei Liu
2016-04-04 14:12 ` Wei Liu
2016-04-01 20:33 ` [PATCH V2 2/9] xentrace: " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 3/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 4/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 5/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 6/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 7/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 8/9] " Benjamin Sanda
2016-04-01 20:33 ` [PATCH V2 9/9] " Benjamin Sanda
2016-04-04 14:11 ` [PATCH V2 0/9] xentrace/xenalyze support on ARM Wei Liu
2016-04-04 15:02 ` Julien Grall [this message]
2016-04-04 15:50 ` Ben Sanda
2016-04-04 15:59 ` Wei Liu
2016-04-04 16:04 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570281FC.3070203@arm.com \
--to=julien.grall@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=ben.sanda@dornerworks.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.