Re: [PATCH i-g-t] lib/igt_kms: Fix atomic plane commit when fb_id is 0.

[Lionel Landwerlin <lionel.g.landwerlin@intel.com>]

Hi Marius,

Thanks for this. I have the same patch on a branch I haven't send yet 
(oops).

In my patch I implemented this by setting src_* to 0 if fb_id == 0.
I'm not sure what makes more sense but anyway :

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>

On 04/04/16 16:47, Marius Vlad wrote:
> igt_atomic_prepare_plane_commit() assumes that the framebuffer is always
> set-up.
>
> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
> ---
>   lib/igt_kms.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 82257a6..30c5b7e 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1585,7 +1585,7 @@ igt_atomic_prepare_plane_commit(igt_plane_t *plane, igt_output_t *output,
>   		igt_atomic_populate_plane_req(req, plane, IGT_PLANE_FB_ID, fb_id);
>   	}
>   
> -	if (plane->position_changed || plane->size_changed) {
> +	if ((plane->position_changed || plane->size_changed) && fb_id != 0) {
>   		uint32_t src_x = IGT_FIXED(plane->fb->src_x, 0); /* src_x */
>   		uint32_t src_y = IGT_FIXED(plane->fb->src_y, 0); /* src_y */
>   		uint32_t src_w = IGT_FIXED(plane->fb->src_w, 0); /* src_w */

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx