Re: [PATCH v3 5/9] libxl: Rearrange qemu upstream disk argument code

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 04/04/16 18:11, Andrew Cooper wrote:
> On 04/04/16 17:59, Ian Jackson wrote:
>> George Dunlap writes ("Re: [PATCH v3 5/9] libxl: Rearrange qemu upstream disk argument code"):
>>> I looked through the patch in the branch provided in your reply to 0/9
>>> [1], and it looks correct; morever, I tested it and it and the basic
>>> functionality (using the "dummy" block script) still works.
>>>
>>> Reviewed-by: George Dunlap <george.dunlap@citrix.com>
>>> Tested-by: George Dunlap <george.dunlap@citrix.com>
>>>
>>> [1] git://xenbits.xenproject.org/people/iwj/xen.git wip.gwd.hotplug-v3.1
>> Thanks, I have pushed it (rebased) to staging.
> New build failure on CentOS 7
>
> libxl_dm.c: In function 'libxl__build_device_model_args':
> libxl_dm.c:1374:27: error: 'target_path' may be used uninitialized in
> this function [-Werror=maybe-uninitialized]
>                      drive = libxl__sprintf(gc, "%s,file=%s,format=%s",
>                            ^
> libxl_dm.c:1310:25: note: 'target_path' was declared here
>              const char *target_path;
>                          ^
> cc1: all warnings being treated as errors

Sorry - sent too early.  Specifically, target_path is genuinely
uninitialised in the case that there is an empty CDROM specified.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel