All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.com>
To: "C.J. Collier KF7BMP" <cjcollier@linuxfoundation.org>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: Example 3 inclusion, Documentation/kbuild/modules.txt:250
Date: Mon, 4 Apr 2016 21:21:56 +0200	[thread overview]
Message-ID: <5702BED4.6070705@suse.com> (raw)
In-Reply-To: <20160404004140.GA10001@linuxfoundation.org>

Dne 4.4.2016 v 02:41 C.J. Collier KF7BMP napsal(a):
> Hello Michal and kbuild team,
> 
> I think I've spotted an error in the module KBuild / Makefile
> documentation.  I believe that the first condition should be executed
> only if KERNELRELEASE is unset, and the rest should be executed
> unconditionally.  Let me know if I'm misreading it.

The second part is there for the sake of convenience, so that one can
type 'make' in the external module directory and it will try to compile
it against the running kernel. It is not something kbuild needs to see.

Also, please follow Documentation/SubmittingPatches and add your signoff
to patches you send. And ideally send the patch inline.

Thanks,
Michal

      reply	other threads:[~2016-04-04 19:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04  0:41 Example 3 inclusion, Documentation/kbuild/modules.txt:250 C.J. Collier KF7BMP
2016-04-04 19:21 ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5702BED4.6070705@suse.com \
    --to=mmarek@suse.com \
    --cc=cjcollier@linuxfoundation.org \
    --cc=linux-kbuild@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.