From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] qt5connectivity: add QtNfc submodule
Date: Mon, 4 Apr 2016 22:13:00 +0200 [thread overview]
Message-ID: <5702CACC.4030702@mind.be> (raw)
In-Reply-To: <1459763762-31640-2-git-send-email-corjon.j@ecagroup.com>
On 04/04/16 11:56, Julien Corjon wrote:
> Signed-off-by: Julien Corjon <corjon.j@ecagroup.com>
> ---
> package/qt5/qt5connectivity/Config.in | 10 ++++++----
> package/qt5/qt5connectivity/qt5connectivity.mk | 4 +++-
> 2 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/package/qt5/qt5connectivity/Config.in b/package/qt5/qt5connectivity/Config.in
> index d529ea7..611ef14 100644
> --- a/package/qt5/qt5connectivity/Config.in
> +++ b/package/qt5/qt5connectivity/Config.in
> @@ -1,13 +1,15 @@
> config BR2_PACKAGE_QT5CONNECTIVITY
> bool "qt5connectivity"
> select BR2_PACKAGE_BLUEZ_UTILS
> + select BR2_PACKAGE_NEARD
> select BR2_PACKAGE_QT5BASE
> select BR2_PACKAGE_QT5BASE_CONCURRENT
> select BR2_PACKAGE_QT5BASE_DBUS
> - depends on !BR2_STATIC_LIBS # bluez_utils
> - depends on BR2_USE_WCHAR # bluez_utils
> - depends on BR2_TOOLCHAIN_HAS_THREADS # bluez_utils
> - depends on BR2_USE_MMU # bluez_utils
> + depends on !BR2_STATIC_LIBS # bluez_utils, neard
> + depends on BR2_USE_WCHAR # bluez_utils, neard
> + depends on BR2_TOOLCHAIN_HAS_THREADS # bluez_utils, neard
> + depends on BR2_USE_MMU # bluez_utils, neard
> + depends on BR2_TOOLCHAIN_HAS_SYNC_4 # neard
My first thought was: this is unnecessarily adding an architecture dependency
to qt5connectivity. However, in practice it doesn't exclude anything that wasn't
excluded already (sparc and arc don't have GL support anyway).
Therefore:
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> help
> Qt is a cross-platform application and UI framework for
> developers using C++.
> diff --git a/package/qt5/qt5connectivity/qt5connectivity.mk b/package/qt5/qt5connectivity/qt5connectivity.mk
> index 936bc6f..ff82b9d 100644
> --- a/package/qt5/qt5connectivity/qt5connectivity.mk
> +++ b/package/qt5/qt5connectivity/qt5connectivity.mk
> @@ -7,7 +7,7 @@
> QT5CONNECTIVITY_VERSION = $(QT5_VERSION)
> QT5CONNECTIVITY_SITE = $(QT5_SITE)
> QT5CONNECTIVITY_SOURCE = qtconnectivity-opensource-src-$(QT5CONNECTIVITY_VERSION).tar.xz
> -QT5CONNECTIVITY_DEPENDENCIES = bluez_utils qt5base
> +QT5CONNECTIVITY_DEPENDENCIES = bluez_utils neard qt5base
> QT5CONNECTIVITY_INSTALL_STAGING = YES
>
> ifeq ($(BR2_PACKAGE_QT5BASE_LICENSE_APPROVED),y)
> @@ -38,12 +38,14 @@ endef
> ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y)
> define QT5CONNECTIVITY_INSTALL_TARGET_QMLS
> cp -dpfr $(STAGING_DIR)/usr/qml/QtBluetooth $(TARGET_DIR)/usr/qml/
> + cp -dpfr $(STAGING_DIR)/usr/qml/QtNfc $(TARGET_DIR)/usr/qml/
> endef
> endif
>
> define QT5CONNECTIVITY_INSTALL_TARGET_CMDS
> cp -dpf $(STAGING_DIR)/usr/lib/libQt5Bluetooth.so.* $(TARGET_DIR)/usr/lib
> cp -dpf $(STAGING_DIR)/usr/bin/sdpscanner $(TARGET_DIR)/usr/bin
> + cp -dpf $(STAGING_DIR)/usr/lib/libQt5Nfc.so.* $(TARGET_DIR)/usr/lib
> $(QT5CONNECTIVITY_INSTALL_TARGET_QMLS)
> endef
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-04-04 20:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 9:56 [Buildroot] [PATCH 1/2] qt5connectivity: add sdpscanner tool for Qt5Bluetooth Julien Corjon
2016-04-04 9:56 ` [Buildroot] [PATCH 2/2] qt5connectivity: add QtNfc submodule Julien Corjon
2016-04-04 20:13 ` Arnout Vandecappelle [this message]
2016-04-13 21:53 ` Thomas Petazzoni
2016-04-18 22:01 ` Thomas Petazzoni
2016-04-19 11:43 ` [Buildroot] [PATCH v2 1/2] " Julien Corjon
2016-04-19 11:43 ` [Buildroot] [PATCH v2 2/2] qt5connectivity: add bluez5_utils option for QtBluetooth submodule Julien Corjon
2016-06-03 17:52 ` Thomas Petazzoni
2016-06-03 17:51 ` [Buildroot] [PATCH v2 1/2] qt5connectivity: add QtNfc submodule Thomas Petazzoni
2016-04-04 10:02 ` [Buildroot] [PATCH 1/2] qt5connectivity: add sdpscanner tool for Qt5Bluetooth Yegor Yefremov
2016-04-04 20:26 ` Arnout Vandecappelle
2016-04-05 14:25 ` Thomas Petazzoni
2016-04-18 22:10 ` Thomas Petazzoni
2016-04-19 10:53 ` Julien CORJON
2016-04-19 11:26 ` Thomas Petazzoni
2016-04-13 21:50 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5702CACC.4030702@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.