From: Lee Duncan <lduncan@suse.com>
To: Andy Grover <agrover@redhat.com>,
Johannes Thumshirn <jthumshirn@suse.de>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
nab@linux-iscsi.org, hch@infradead.org, lkml@vger.kernel.org,
hare@suse.com, linux-scsi-owner@vger.kernel.org
Subject: Re: [PATCH 2/2] target: use new "dbroot" target attribute
Date: Mon, 4 Apr 2016 18:09:27 -0700 [thread overview]
Message-ID: <57031047.9060302@suse.com> (raw)
In-Reply-To: <56FEBB5A.2000205@redhat.com>
On 04/01/2016 11:18 AM, Andy Grover wrote:
> On 04/01/2016 11:01 AM, Lee Duncan wrote:
>> On 04/01/2016 12:58 AM, Johannes Thumshirn wrote:
>>> On 2016-03-31 20:05, Lee Duncan wrote:
>>>> This commit updates the target core ALUA and PR
>>>> modules to use the new "dbroot" attribute instead
>>>> of assuming the target database is in "/var/target".
>>>
>>> Same goes for this one,
>>>
>>> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>>> as soon as it has a Signed-off-by line
>>
>> Thanks Johannes.
>>
>> I will wait to see if there are any other comments, then resubmit v2.
>
> Seems fine to me, too.
Thank you for your review.
>
> So, if not /var/target, where do you recommend we be pointing this to?
>
Good question!
For testing, I put it in /etc/target/target_db. But /etc is supposed to
be for configuration data.
Part of my problem in picking a place was that there seems to be two
different kinds of data there: policy, and state.
Since it was not my intention to sort that out, I just picked the /etc
location mentioned and verified it could work.
next prev parent reply other threads:[~2016-04-05 1:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 18:05 [PATCH 0/2] target: make location of /var/target configurable Lee Duncan
2016-03-31 18:05 ` [PATCH 1/2] target: Make target db location configurable Lee Duncan
2016-04-01 7:57 ` Johannes Thumshirn
2016-03-31 18:05 ` [PATCH 2/2] target: use new "dbroot" target attribute Lee Duncan
2016-04-01 7:58 ` Johannes Thumshirn
2016-04-01 18:01 ` Lee Duncan
2016-04-01 18:18 ` Andy Grover
2016-04-05 1:09 ` Lee Duncan [this message]
2016-04-03 3:36 ` [PATCH 0/2] target: make location of /var/target configurable Nicholas A. Bellinger
2016-04-05 1:15 ` Lee Duncan
2016-04-05 2:15 ` Nicholas A. Bellinger
-- strict thread matches above, loose matches on Subject: below --
2016-04-13 20:25 [PATCHv2 0/2] target: make location of /var/targets configurable Lee Duncan
2016-04-13 20:25 ` [PATCH 2/2] target: use new "dbroot" target attribute Lee Duncan
2016-04-13 20:25 ` Lee Duncan
2016-04-14 6:10 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57031047.9060302@suse.com \
--to=lduncan@suse.com \
--cc=agrover@redhat.com \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=jthumshirn@suse.de \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkml@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.