From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Duncan Subject: Re: [PATCH 2/2] target: use new "dbroot" target attribute Date: Mon, 4 Apr 2016 18:09:27 -0700 Message-ID: <57031047.9060302@suse.com> References: <394f77609c81d2274cee31a51318d89e@suse.de> <56FEB771.7090901@suse.com> <56FEBB5A.2000205@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56FEBB5A.2000205@redhat.com> Sender: target-devel-owner@vger.kernel.org To: Andy Grover , Johannes Thumshirn Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, nab@linux-iscsi.org, hch@infradead.org, lkml@vger.kernel.org, hare@suse.com, linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On 04/01/2016 11:18 AM, Andy Grover wrote: > On 04/01/2016 11:01 AM, Lee Duncan wrote: >> On 04/01/2016 12:58 AM, Johannes Thumshirn wrote: >>> On 2016-03-31 20:05, Lee Duncan wrote: >>>> This commit updates the target core ALUA and PR >>>> modules to use the new "dbroot" attribute instead >>>> of assuming the target database is in "/var/target". >>> >>> Same goes for this one, >>> >>> Reviewed-by: Johannes Thumshirn >>> as soon as it has a Signed-off-by line >> >> Thanks Johannes. >> >> I will wait to see if there are any other comments, then resubmit v2. > > Seems fine to me, too. Thank you for your review. > > So, if not /var/target, where do you recommend we be pointing this to? > Good question! For testing, I put it in /etc/target/target_db. But /etc is supposed to be for configuration data. Part of my problem in picking a place was that there seems to be two different kinds of data there: policy, and state. Since it was not my intention to sort that out, I just picked the /etc location mentioned and verified it could work.