All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: <dsterba@suse.cz>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs-progs: fsck: Fix a false metadata extent warning
Date: Tue, 5 Apr 2016 09:28:31 +0800	[thread overview]
Message-ID: <570314BF.209@cn.fujitsu.com> (raw)
In-Reply-To: <20160404111852.GG9918@twin.jikos.cz>



David Sterba wrote on 2016/04/04 13:18 +0200:
> On Fri, Apr 01, 2016 at 04:50:06PM +0800, Qu Wenruo wrote:
>>> After another look, why don't we use nodesize directly? Or stripesize
>>> where applies. With max_size == 0 the test does not make sense, we ought
>>> to know the alignment.
>>>
>>>
>> Yes, my first though is also to use nodesize directly, which should be
>> always correct.
>>
>> But the problem is, the related function call stack doesn't have any
>> member to reach btrfs_root or btrfs_fs_info.
>
> JFYI, there's global_info avalaible, so it's not necessary to pass
> fs_info down the callstacks.
>
>
Oh, that's a good news.

Do I need to re-submit the patch to use fs_info->tree_root->nodesize to 
avoid false alert?
Or wait for your refactor?

Thanks,
Qu



  reply	other threads:[~2016-04-05  1:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31  2:19 [PATCH] btrfs-progs: fsck: Fix a false metadata extent warning Qu Wenruo
2016-03-31 16:30 ` David Sterba
2016-04-01  0:28   ` Qu Wenruo
2016-04-01  8:44     ` David Sterba
2016-04-01  8:50       ` Qu Wenruo
2016-04-01 11:39         ` David Sterba
2016-04-01 12:09           ` Qu Wenruo
2016-04-01 12:48             ` David Sterba
2016-04-04 11:18         ` David Sterba
2016-04-05  1:28           ` Qu Wenruo [this message]
2016-04-05  8:43             ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570314BF.209@cn.fujitsu.com \
    --to=quwenruo@cn.fujitsu.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.