From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kefeng Wang Subject: Re: [PATCH v3] serial: 8250_dw: fix wrong logic in dw8250_check_lcr() Date: Tue, 5 Apr 2016 12:55:22 +0800 Message-ID: <5703453A.8040504@huawei.com> References: <1459827166-13861-1-git-send-email-wangkefeng.wang@huawei.com> <20160405040240.GA24639@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160405040240.GA24639@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: Greg Kroah-Hartman Cc: Noam Camus , Andy Shevchenko , Heikki Krogerus , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, guohanjun@huawei.com, xuwei5@hisilicon.com List-Id: linux-serial@vger.kernel.org On 2016/4/5 12:02, Greg Kroah-Hartman wrote: > On Tue, Apr 05, 2016 at 11:32:46AM +0800, Kefeng Wang wrote: >> Commit cdcea058e510 ("serial: 8250_dw: Avoid serial_outx code duplicate >> with new dw8250_check_lcr()") introduce a wrong logic when write val to >> LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used unconditionally. >> >> The __raw_readq/__raw_writeq is introduced by commit bca2092d7897 ("serial: >> 8250_dw: Use 64-bit access for OCTEON.") for OCTEON, so for !PORT_OCTEON, >> we better to use coincident write func. >> >> Fixes: cdcea058e510("serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr()") >> Signed-off-by: Kefeng Wang >> --- >> Keep #ifdef CONFIG_64BIT to ensure it built under arch lacking readq/writeq. >> >> drivers/tty/serial/8250/8250_dw.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) > > What changed between all of these versions? Always document that below > the --- line otherwise I think they are all the same and I'll just > delete them all :) Thanks for your guidance, will add log if with different versions to show what changes. > > v4 please. Ok, thanks again. > > thanks, > > greg k-h > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757358AbcDEE4H (ORCPT ); Tue, 5 Apr 2016 00:56:07 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:26149 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753082AbcDEE4E (ORCPT ); Tue, 5 Apr 2016 00:56:04 -0400 Subject: Re: [PATCH v3] serial: 8250_dw: fix wrong logic in dw8250_check_lcr() To: Greg Kroah-Hartman References: <1459827166-13861-1-git-send-email-wangkefeng.wang@huawei.com> <20160405040240.GA24639@kroah.com> CC: Noam Camus , Andy Shevchenko , Heikki Krogerus , , , , From: Kefeng Wang Message-ID: <5703453A.8040504@huawei.com> Date: Tue, 5 Apr 2016 12:55:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160405040240.GA24639@kroah.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.180] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.57034549.00CF,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 79d3f9caee3f7311c87bfa6d499ee676 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/4/5 12:02, Greg Kroah-Hartman wrote: > On Tue, Apr 05, 2016 at 11:32:46AM +0800, Kefeng Wang wrote: >> Commit cdcea058e510 ("serial: 8250_dw: Avoid serial_outx code duplicate >> with new dw8250_check_lcr()") introduce a wrong logic when write val to >> LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used unconditionally. >> >> The __raw_readq/__raw_writeq is introduced by commit bca2092d7897 ("serial: >> 8250_dw: Use 64-bit access for OCTEON.") for OCTEON, so for !PORT_OCTEON, >> we better to use coincident write func. >> >> Fixes: cdcea058e510("serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr()") >> Signed-off-by: Kefeng Wang >> --- >> Keep #ifdef CONFIG_64BIT to ensure it built under arch lacking readq/writeq. >> >> drivers/tty/serial/8250/8250_dw.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) > > What changed between all of these versions? Always document that below > the --- line otherwise I think they are all the same and I'll just > delete them all :) Thanks for your guidance, will add log if with different versions to show what changes. > > v4 please. Ok, thanks again. > > thanks, > > greg k-h > > . >