From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <6e2cf6821542a253904dfc7d8ec431d6bbda2b4e.1459827115.git.lucien.xin@gmail.com> <6197a35a2eb6df2caf90edcbf1b49da12077f659.1459827115.git.lucien.xin@gmail.com> From: Toshiaki Makita Message-ID: <5703483D.80109@lab.ntt.co.jp> Date: Tue, 5 Apr 2016 14:08:13 +0900 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCHv2 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge_parm List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xin Long , network dev , bridge@lists.linux-foundation.org Cc: nikolay@cumulusnetworks.com, davem@davemloft.net On 2016/04/05 12:32, Xin Long wrote: > There are some repetitive codes in stp_state_store, we can remove > them by calling store_bridge_parm. > > Signed-off-by: Xin Long > --- > net/bridge/br_sysfs_br.c | 24 +++++++----------------- > 1 file changed, 7 insertions(+), 17 deletions(-) > > diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c > index 137cd3b..9918763 100644 > --- a/net/bridge/br_sysfs_br.c > +++ b/net/bridge/br_sysfs_br.c > @@ -128,27 +128,17 @@ static ssize_t stp_state_show(struct device *d, > } > > > +static int set_stp_state(struct net_bridge *br, unsigned long val) > +{ You forgot to add rtnl lock here? The missing lock is restored in patch 4, but at this point bisect could break.. > + br_stp_set_enabled(br, val); > + return 0; > +} Toshiaki Makita From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toshiaki Makita Subject: Re: [PATCHv2 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge_parm Date: Tue, 5 Apr 2016 14:08:13 +0900 Message-ID: <5703483D.80109@lab.ntt.co.jp> References: <6e2cf6821542a253904dfc7d8ec431d6bbda2b4e.1459827115.git.lucien.xin@gmail.com> <6197a35a2eb6df2caf90edcbf1b49da12077f659.1459827115.git.lucien.xin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Cc: nikolay@cumulusnetworks.com, davem@davemloft.net To: Xin Long , network dev , bridge@lists.linux-foundation.org Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 2016/04/05 12:32, Xin Long wrote: > There are some repetitive codes in stp_state_store, we can remove > them by calling store_bridge_parm. > > Signed-off-by: Xin Long > --- > net/bridge/br_sysfs_br.c | 24 +++++++----------------- > 1 file changed, 7 insertions(+), 17 deletions(-) > > diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c > index 137cd3b..9918763 100644 > --- a/net/bridge/br_sysfs_br.c > +++ b/net/bridge/br_sysfs_br.c > @@ -128,27 +128,17 @@ static ssize_t stp_state_show(struct device *d, > } > > > +static int set_stp_state(struct net_bridge *br, unsigned long val) > +{ You forgot to add rtnl lock here? The missing lock is restored in patch 4, but at this point bisect could break.. > + br_stp_set_enabled(br, val); > + return 0; > +} Toshiaki Makita