From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Decouple execbuf uAPI from internal implementation Date: Tue, 5 Apr 2016 10:17:25 +0100 Message-ID: <570382A5.40306@linux.intel.com> References: <1452783779-2364-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20160114220916.GA15852@nuc-i3427.alporthouse.com> <1EA3C154D402DC44897E491310ECC48D73397967@IRSMSX106.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 229996E0D9 for ; Tue, 5 Apr 2016 09:17:28 +0000 (UTC) In-Reply-To: <1EA3C154D402DC44897E491310ECC48D73397967@IRSMSX106.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Kukanova, Svetlana" , Chris Wilson Cc: Daniel Vetter , "Intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org CkhpLAoKT24gMjUvMDMvMTYgMTM6MTgsIEt1a2Fub3ZhLCBTdmV0bGFuYSB3cm90ZToKPiBIaSBl dmVyeW9uZSwKPgo+IFllcywgdGhpcyBicmVha3MgdXNlcnNwYWNlIEFCSSBhbmQgaW4gcGFydGlj dWxhciBpdCBicm9rZSBWVHVuZSB3b3JrLgo+IFJpbmcgaWRzIGFyZSBzZWVuIHZpYSBpOTE1IHRy YWNlcG9pbnRzLCBhbmQgVlR1bmUgQW1wbGlmaWVyIHVzZXMgdGhlbS4KPiBXZSB3ZXJlIHJlbHlp bmcgb24gdGhlIG9sZCByaW5nIGlkcywgYW5kIGFzc3VtaW5nIHRoYXQgdGhlIG5ldyByaW5ncyB3 b3VsZCBiZSBhZGRlZCB0byB0aGUgZW5kIG9mIHRoZSBlbnVtLgo+Cj4gSSdtIG9iamVjdGluZyBq dXN0IG5vdyBiZWNhdXNlIG5vdyB0aGlzIGRyaXZlciBjaGFuZ2UgcmVhY2hlZCBvdXIgaW50ZXJu YWwgdXNlcnMgYW5kIHRoZXkgY29tcGxhaW5lZCB0aGF0IFZUdW5lIGlzIHJlcG9ydGluZyBETUEg cGFja2V0cyBvbiB3cm9uZyBlbmdpbmVzLgo+Cj4gSSB3b3VsZCByZXF1ZXN0IHRoaXMgY2hhbmdl ICh0aGUgZW51bSBpbnRlbF9yaW5nX2lkIGNoYW5nZSkgdG8gYmUgcm9sbGVkIGJhY2suIEhvcGUs IGl0J3Mgc3RpbGwgcG9zc2libGUuCgpUaGlzIG9uZSB3aWxsIGJlIHRoZSBvbmUgZm9yIERhbmll bC4gUGVyc29uYWxseSBJIGRpZG4ndCB0aGluayAKdHJhY2Vwb2ludHMgY291bnQgYXMgQUJJLCBp ZiB5b3UgY29uc2lkZXIgdGhleSBjYW4gc3RhcnQgYW5kIHN0b3AgbWFraW5nIApzZW5zZSBqdXN0 IGJ5IHRoZSB2aXJ0dWUgb2YgaW50ZXJuYWwgZHJpdmVyIHJlZmFjdG9yaW5nLgoKQnV0IGFzIGEg cXVpY2sgR29vZ2xlIHNlYXJjaCBzaG93cywgdGhlcmUgaXMgc29tZSBjb250cm92ZXJzeSBvbiB0 aGUgCnRvcGljLCBldmVuIGlmIGl0IGlzIHN0aWxsIHF1ZXN0aW9uYWJsZSBmb3IgZGV2aWNlIGRy aXZlcnMuCgpBbHNvLCBjb3VsZCB5b3Ugbm90IGRldGVjdCB0aGUgaTkxNSB2ZXJzaW9uIHNvbWVo b3cgZnJvbSBWVHVuZSBhbmQgYWRhcHQ/CgpSZWdhcmRzLAoKVHZydGtvCgo+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tCj4gRnJvbTogSW50ZWwtZ2Z4IFttYWlsdG86aW50ZWwtZ2Z4LWJvdW5j ZXNAbGlzdHMuZnJlZWRlc2t0b3Aub3JnXSBPbiBCZWhhbGYgT2YgQ2hyaXMgV2lsc29uCj4gU2Vu dDogRnJpZGF5LCBKYW51YXJ5IDE1LCAyMDE2IDE6MDkgQU0KPiBUbzogVHZydGtvIFVyc3VsaW4g PHR2cnRrby51cnN1bGluQGxpbnV4LmludGVsLmNvbT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFu aWVsLnZldHRlckBmZndsbC5jaD47IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBT dWJqZWN0OiBSZTogW0ludGVsLWdmeF0gW1BBVENIXSBkcm0vaTkxNTogRGVjb3VwbGUgZXhlY2J1 ZiB1QVBJIGZyb20gaW50ZXJuYWwgaW1wbGVtZW50YXRpb24KPgo+IE9uIFRodSwgSmFuIDE0LCAy MDE2IGF0IDAzOjAyOjU5UE0gKzAwMDAsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+PiBGcm9tOiBU dnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pgo+PiBBdCB0aGUgbW9t ZW50IGV4ZWNidWYgcmluZyBzZWxlY3Rpb24gaXMgZnVsbHkgY291cGxlZCB0byBpbnRlcm5hbCBy aW5nCj4+IGlkcyB3aGljaCBpcyBub3QgYSBnb29kIHRoaW5nIG9uIGl0cyBvd24uCj4+Cj4+IFRo aXMgZGVwZW5kZW5jeSBpcyBhbHNvIHNwcmVhZCBiZXR3ZWVuIHR3byBzb3VyY2UgZmlsZXMgYW5k IG5vdAo+PiBzcGVsbGVkIG91dCBhdCBlaXRoZXIgc2lkZSB3aGljaCBtYWtlcyBpdCBoaWRkZW4g YW5kIGZyYWdpbGUuCj4+Cj4+IFRoaXMgcGF0Y2ggZGVjb3VwbGVzIHRoaXMgZGVwZW5kZW5jeSBi eSBpbnRyb2R1Y2luZyBhbiBleHBsaWNpdAo+PiB0cmFuc2xhdGlvbiB0YWJsZSBvZiBleGVjYnVm IHVBUEkgdG8gcmluZyBpZCBjbG9zZSB0byB0aGUgb25seSBjYWxsCj4+IHNpdGUgKGk5MTVfZ2Vt X2RvX2V4ZWNidWZmZXIpLgo+Pgo+PiBUaGlzIHdheSB3ZSBhcmUgZnJlZSB0byBjaGFuZ2UgZHJp dmVyIGludGVybmFsIGltcGxlbWVudGF0aW9uIGRldGFpbHMKPj4gd2l0aG91dCBicmVha2luZyB1 c2Vyc3BhY2UuIEFsbCBzdGF0ZSByZWxhdGluZyB0byB0aGUgdUFQSSBpcyBub3cKPj4gY29udGFp bmVkIGluLCBvciBuZXh0IHRvLCBpOTE1X2dlbV9kb19leGVjYnVmZmVyLgo+Cj4gSSB3YXMgaGVz aXN0YW50IGF0IGZpcnN0LCBzaW5jZSAid2h5PyIgaXNuJ3QgZnVsbHkgZGV2ZWxvcGVkLCBidXQg dGhlIGNvZGUgd29uIG1lIG92ZXIuCj4KPj4gKyNkZWZpbmUgSTkxNV9VU0VSX1JJTkdTICg0KQo+ PiArCj4+ICtzdGF0aWMgY29uc3QgZW51bSBpbnRlbF9yaW5nX2lkIHVzZXJfcmluZ19tYXBbSTkx NV9VU0VSX1JJTkdTICsgMV0gPSB7Cj4+ICsJW0k5MTVfRVhFQ19ERUZBVUxUXQk9IFJDUywKPj4g KwlbSTkxNV9FWEVDX1JFTkRFUl0JPSBSQ1MsCj4+ICsJW0k5MTVfRVhFQ19CTFRdCQk9IEJDUywK Pj4gKwlbSTkxNV9FWEVDX0JTRF0JCT0gVkNTLAo+PiArCVtJOTE1X0VYRUNfVkVCT1hdCT0gVkVD Uwo+PiArfTsKPgo+IEkgd2FzIHdvbmRlcmluZyB3aGV0aGVyIHBhY2tpbmcgaGVyZSBtYXR0ZXJl ZCBhdCBhbGwsIGJ1dCB3ZSdyZSB1bmRlciBhIGNhY2hlbGluZSBzbyBoaWdobHkgdW5saWtlbHku Cj4KPj4gICBzdGF0aWMgaW50Cj4+ICAgaTkxNV9nZW1fZG9fZXhlY2J1ZmZlcihzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+PiAgIAkJICAgICAgIHN0cnVjdCBkcm1fZmlsZSAq ZmlsZSwKPj4gQEAgLTEzOTMsNiArMTM5Myw3IEBAIGk5MTVfZ2VtX2RvX2V4ZWNidWZmZXIoc3Ry dWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPj4gICAJc3RydWN0IGk5MTVfZXhlY2J1 ZmZlcl9wYXJhbXMgcGFyYW1zX21hc3RlcjsgLyogWFhYOiB3aWxsIGJlIHJlbW92ZWQgbGF0ZXIg Ki8KPj4gICAJc3RydWN0IGk5MTVfZXhlY2J1ZmZlcl9wYXJhbXMgKnBhcmFtcyA9ICZwYXJhbXNf bWFzdGVyOwo+PiAgIAljb25zdCB1MzIgY3R4X2lkID0gaTkxNV9leGVjYnVmZmVyMl9nZXRfY29u dGV4dF9pZCgqYXJncyk7Cj4+ICsJdW5zaWduZWQgaW50IHVzZXJfcmluZ19pZCA9IGFyZ3MtPmZs YWdzICYgSTkxNV9FWEVDX1JJTkdfTUFTSzsKPj4gICAJdTMyIGRpc3BhdGNoX2ZsYWdzOwo+PiAg IAlpbnQgcmV0Owo+PiAgIAlib29sIG5lZWRfcmVsb2NzOwo+PiBAQCAtMTQxNCw0OSArMTQxNSwz OSBAQCBpOTE1X2dlbV9kb19leGVjYnVmZmVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQg KmRhdGEsCj4+ICAgCWlmIChhcmdzLT5mbGFncyAmIEk5MTVfRVhFQ19JU19QSU5ORUQpCj4+ICAg CQlkaXNwYXRjaF9mbGFncyB8PSBJOTE1X0RJU1BBVENIX1BJTk5FRDsKPj4KPj4gLQlpZiAoKGFy Z3MtPmZsYWdzICYgSTkxNV9FWEVDX1JJTkdfTUFTSykgPiBMQVNUX1VTRVJfUklORykgewo+PiAt CQlEUk1fREVCVUcoImV4ZWNidWYgd2l0aCB1bmtub3duIHJpbmc6ICVkXG4iLAo+PiAtCQkJICAo aW50KShhcmdzLT5mbGFncyAmIEk5MTVfRVhFQ19SSU5HX01BU0spKTsKPj4gKwlpZiAodXNlcl9y aW5nX2lkID4gSTkxNV9VU0VSX1JJTkdTKSB7Cj4+ICsJCURSTV9ERUJVRygiZXhlY2J1ZiB3aXRo IHVua25vd24gcmluZzogJXVcbiIsIHVzZXJfcmluZ19pZCk7Cj4+ICAgCQlyZXR1cm4gLUVJTlZB TDsKPj4gICAJfQo+Pgo+PiAtCWlmICgoKGFyZ3MtPmZsYWdzICYgSTkxNV9FWEVDX1JJTkdfTUFT SykgIT0gSTkxNV9FWEVDX0JTRCkgJiYKPj4gKwlpZiAoKHVzZXJfcmluZ19pZCAhPSBJOTE1X0VY RUNfQlNEKSAmJgo+PiAgIAkgICAgKChhcmdzLT5mbGFncyAmIEk5MTVfRVhFQ19CU0RfTUFTSykg IT0gMCkpIHsKPj4gICAJCURSTV9ERUJVRygiZXhlY2J1ZiB3aXRoIG5vbiBic2QgcmluZyBidXQg d2l0aCBpbnZhbGlkICIKPj4gICAJCQkiYnNkIGRpc3BhdGNoIGZsYWdzOiAlZFxuIiwgKGludCko YXJncy0+ZmxhZ3MpKTsKPj4gICAJCXJldHVybiAtRUlOVkFMOwo+PiAtCX0KPj4gLQo+PiAtCWlm ICgoYXJncy0+ZmxhZ3MgJiBJOTE1X0VYRUNfUklOR19NQVNLKSA9PSBJOTE1X0VYRUNfREVGQVVM VCkKPj4gLQkJcmluZyA9ICZkZXZfcHJpdi0+cmluZ1tSQ1NdOwo+PiAtCWVsc2UgaWYgKChhcmdz LT5mbGFncyAmIEk5MTVfRVhFQ19SSU5HX01BU0spID09IEk5MTVfRVhFQ19CU0QpIHsKPj4gLQkJ aWYgKEhBU19CU0QyKGRldikpIHsKPj4gLQkJCWludCByaW5nX2lkOwo+PiAtCj4+IC0JCQlzd2l0 Y2ggKGFyZ3MtPmZsYWdzICYgSTkxNV9FWEVDX0JTRF9NQVNLKSB7Cj4+IC0JCQljYXNlIEk5MTVf RVhFQ19CU0RfREVGQVVMVDoKPj4gLQkJCQlyaW5nX2lkID0gZ2VuOF9kaXNwYXRjaF9ic2Rfcmlu ZyhkZXYsIGZpbGUpOwo+PiAtCQkJCXJpbmcgPSAmZGV2X3ByaXYtPnJpbmdbcmluZ19pZF07Cj4+ IC0JCQkJYnJlYWs7Cj4+IC0JCQljYXNlIEk5MTVfRVhFQ19CU0RfUklORzE6Cj4+IC0JCQkJcmlu ZyA9ICZkZXZfcHJpdi0+cmluZ1tWQ1NdOwo+PiAtCQkJCWJyZWFrOwo+PiAtCQkJY2FzZSBJOTE1 X0VYRUNfQlNEX1JJTkcyOgo+PiAtCQkJCXJpbmcgPSAmZGV2X3ByaXYtPnJpbmdbVkNTMl07Cj4+ IC0JCQkJYnJlYWs7Cj4+IC0JCQlkZWZhdWx0Ogo+PiAtCQkJCURSTV9ERUJVRygiZXhlY2J1ZiB3 aXRoIHVua25vd24gYnNkIHJpbmc6ICVkXG4iLAo+PiAtCQkJCQkgIChpbnQpKGFyZ3MtPmZsYWdz ICYgSTkxNV9FWEVDX0JTRF9NQVNLKSk7Cj4+IC0JCQkJcmV0dXJuIC1FSU5WQUw7Cj4+IC0JCQl9 Cj4+IC0JCX0gZWxzZQo+PiAtCQkJcmluZyA9ICZkZXZfcHJpdi0+cmluZ1tWQ1NdOwo+PiAtCX0g ZWxzZQo+PiAtCQlyaW5nID0gJmRldl9wcml2LT5yaW5nWyhhcmdzLT5mbGFncyAmIEk5MTVfRVhF Q19SSU5HX01BU0spIC0gMV07Cj4+ICsJfQo+PiArCj4+ICsJaWYgKHVzZXJfcmluZ19pZCA9PSBJ OTE1X0VYRUNfQlNEICYmIEhBU19CU0QyKGRldikpIHsKPgo+IEhBU19CU0QyKGRldl9wcml2KQo+ Cj4+ICsJCXVuc2lnbmVkIGludCBic2RfaWR4ID0gYXJncy0+ZmxhZ3MgJiBJOTE1X0VYRUNfQlNE X01BU0s7Cj4+ICsKPj4gKwkJaWYgKGJzZF9pZHggPT0gSTkxNV9FWEVDX0JTRF9ERUZBVUxUKSB7 Cj4+ICsJCQlic2RfaWR4ID0gZ2VuOF9kaXNwYXRjaF9ic2RfcmluZyhkZXZfcHJpdiwgZmlsZSk7 Cj4+ICsJCX0gZWxzZSBpZiAoYnNkX2lkeCA+PSBJOTE1X0VYRUNfQlNEX1JJTkcxICYmCj4+ICsJ CQkgICBic2RfaWR4IDw9IEk5MTVfRVhFQ19CU0RfUklORzIpIHsKPj4gKwkJCWJzZF9pZHgtLTsK Pj4gKwkJfSBlbHNlIHsKPj4gKwkJCURSTV9ERUJVRygiZXhlY2J1ZiB3aXRoIHVua25vd24gYnNk IHJpbmc6ICV1XG4iLAo+PiArCQkJCSAgYnNkX2lkeCk7Cj4+ICsJCQlyZXR1cm4gLUVJTlZBTDsK Pj4gKwkJfQo+PiArCj4+ICsJCXJpbmcgPSAmZGV2X3ByaXYtPnJpbmdbX1ZDUyhic2RfaWR4KV07 Cj4+ICsJfSBlbHNlIHsKPj4gKwkJcmluZyA9ICZkZXZfcHJpdi0+cmluZ1t1c2VyX3JpbmdfbWFw W3VzZXJfcmluZ19pZF1dOwo+PiArCX0KPj4KPj4gICAJaWYgKCFpbnRlbF9yaW5nX2luaXRpYWxp emVkKHJpbmcpKSB7Cj4+IC0JCURSTV9ERUJVRygiZXhlY2J1ZiB3aXRoIGludmFsaWQgcmluZzog JWRcbiIsCj4+IC0JCQkgIChpbnQpKGFyZ3MtPmZsYWdzICYgSTkxNV9FWEVDX1JJTkdfTUFTSykp Owo+PiArCQlEUk1fREVCVUcoImV4ZWNidWYgd2l0aCBpbnZhbGlkIHJpbmc6ICV1XG4iLCB1c2Vy X3JpbmdfaWQpOwo+PiAgIAkJcmV0dXJuIC1FSU5WQUw7Cj4+ICAgCX0KPgo+IE9uZSBxdWVzdGlv biwgaG93IGRvZXMgdGhpcyBsb29rIGlmIHdlIG1vdmUgdGhpcyBzZWN0aW9uIHRvIGl0cyBvd24K PiBmdW5jdGlvbjoKPgo+IHJpbmcgPSBlYl9zZWxlY3RfcmluZyhkZXZfcHJpdiwgZmlsZSwgYXJn cyk7IGlmIChJU19FUlIocmluZykpCj4gCXJldHVybiBQVFJfRVJSKHJpbmcpOwo+Cj4gRG8geW91 IGtlZXAgeW91ciBjb2RlIHNpemUgcmVkdWN0aW9uPwo+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9yaW5nYnVmZmVyLmgKPj4gaW5kZXggNzM0OWQ5MjU4MTkxLi5mZGMyMjBmYzJiMTgg MTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPj4gQEAgLTE0 OCwxNCArMTQ4LDE0IEBAIHN0cnVjdCAgaTkxNV9jdHhfd29ya2Fyb3VuZHMgeyAgc3RydWN0Cj4+ IGludGVsX2VuZ2luZV9jcyB7Cj4+ICAgCWNvbnN0IGNoYXIJKm5hbWU7Cj4+ICAgCWVudW0gaW50 ZWxfcmluZ19pZCB7Cj4+IC0JCVJDUyA9IDB4MCwKPj4gLQkJVkNTLAo+PiArCQlSQ1MgPSAwLAo+ PiAgIAkJQkNTLAo+PiAtCQlWRUNTLAo+PiAtCQlWQ1MyCj4+ICsJCVZDUywKPj4gKwkJVkNTMiwJ LyogS2VlcCBpbnN0YW5jZXMgb2YgdGhlIHNhbWUgdHlwZSBlbmdpbmUgdG9nZXRoZXIuICovCj4+ ICsJCVZFQ1MKPgo+IFRlY2huaWNhbGx5LCB0aGlzIGJyZWFrcyB1c2Vyc3BhY2UgQUJJIGVsc2V3 aGVyZS4gOnwgVGhvdWdoIHRoZSBvbmx5IHVzZXIgb2YgdGhlIGlkIG1hc2sgaXMgb25seSBsb29r aW5nIGZvciBSQ1M9PTAgdnMgdGhlIHJlc2V0Lgo+Cj4gU28gSSB0aGluayB3ZSB3b3VsZCBjb3Bl LCBidXQgdG8gYmUgZXh0cmEgc2FmZSB3ZSBjb3VsZCBqdXN0IGF2b2lkIHJlc2h1ZmZsaW5nIHRo ZSBpZHMuIExldCBtZSBzbGVlcCBvbiB0aGUgaW1wbGljYXRpb25zLiBXZSBtYXkgc2F5IGp1c3Qg YnJlYWsgdGhhdCBBQkkgd2hpbHN0IHdlIHN0aWxsIGNhbiBhbmQgZG8gYSByZXZlcnNlLW1hcCB0 byBFWEVDIGJpdC4KPiBIbW0uCj4gLUNocmlzCj4KPiAtLQo+IENocmlzIFdpbHNvbiwgSW50ZWwg T3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50cmUgX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngKPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK