All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Bruce Rogers <brogers@suse.com>
Subject: Re: [Qemu-devel] [PATCH] crypto: fix nettle config check for running pbkdf test
Date: Tue, 5 Apr 2016 11:40:32 +0200	[thread overview]
Message-ID: <57038810.60402@redhat.com> (raw)
In-Reply-To: <1459783474-23588-1-git-send-email-berrange@redhat.com>



On 04/04/2016 17:24, Daniel P. Berrange wrote:
> The pbkdf test is being built based on a check for CONFIG_NETTLE.
> As of fff2f982ab6ac0dd2b641d30303f72270a019f28, it should be
> instead checking CONFIG_NETTLE_KDF
> 
> Reported-by: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Reported-by: Bruce Rogers <brogers@suse.com>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  tests/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index 45b9048..651d8b2 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -92,7 +92,7 @@ check-unit-$(CONFIG_GNUTLS) += tests/test-io-channel-tls$(EXESUF)
>  check-unit-y += tests/test-io-channel-command$(EXESUF)
>  check-unit-y += tests/test-io-channel-buffer$(EXESUF)
>  check-unit-y += tests/test-base64$(EXESUF)
> -check-unit-$(if $(CONFIG_NETTLE),y,$(CONFIG_GCRYPT_KDF)) += tests/test-crypto-pbkdf$(EXESUF)
> +check-unit-$(if $(CONFIG_NETTLE_KDF),y,$(CONFIG_GCRYPT_KDF)) += tests/test-crypto-pbkdf$(EXESUF)
>  check-unit-y += tests/test-crypto-ivgen$(EXESUF)
>  check-unit-y += tests/test-crypto-afsplit$(EXESUF)
>  check-unit-y += tests/test-crypto-xts$(EXESUF)

Peter, could you please apply this directly to master for rc1?

Thanks,

Paolo

  parent reply	other threads:[~2016-04-05  9:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 15:24 [Qemu-devel] [PATCH] crypto: fix nettle config check for running pbkdf test Daniel P. Berrange
2016-04-04 20:01 ` Bruce Rogers
2016-04-05  1:19   ` Ed Maste
2016-04-05  9:40 ` Paolo Bonzini [this message]
2016-04-05  9:58   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57038810.60402@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=berrange@redhat.com \
    --cc=brogers@suse.com \
    --cc=dgilbert@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.