From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anNjx-0008I3-Ui for qemu-devel@nongnu.org; Tue, 05 Apr 2016 05:57:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anNju-0003G9-Ot for qemu-devel@nongnu.org; Tue, 05 Apr 2016 05:57:41 -0400 Received: from [59.151.112.132] (port=8546 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anNju-0003Bs-68 for qemu-devel@nongnu.org; Tue, 05 Apr 2016 05:57:38 -0400 References: <1459849818-26649-1-git-send-email-pbonzini@redhat.com> <1459849818-26649-11-git-send-email-pbonzini@redhat.com> From: Cao jin Message-ID: <57038C9E.30405@cn.fujitsu.com> Date: Tue, 5 Apr 2016 17:59:58 +0800 MIME-Version: 1.0 In-Reply-To: <1459849818-26649-11-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 10/15] doc/memory: update MMIO section List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org On 04/05/2016 05:50 PM, Paolo Bonzini wrote: > From: Cao jin > > There is no memory_region_io(). And remove a stray '-'. > > Signed-off-by: Cao jin > Message-Id: <1459507677-16662-1-git-send-email-caoj.fnst@cn.fujitsu.com> > Signed-off-by: Paolo Bonzini > --- > docs/memory.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/memory.txt b/docs/memory.txt > index 97134e1..f9272ca 100644 > --- a/docs/memory.txt > +++ b/docs/memory.txt > @@ -37,8 +37,8 @@ MemoryRegion): > > - MMIO: a range of guest memory that is implemented by host callbacks; > each read or write causes a callback to be called on the host. > - You initialize these with memory_region_io(), passing it a MemoryRegionOps > - structure describing the callbacks. > + You initialize these with memory_region_init_io(), passing it a > + MemoryRegionOps structure describing the callbacks. > > - ROM: a ROM memory region works like RAM for reads (directly accessing > a region of host memory), but like MMIO for writes (invoking a callback). > Hi Paolo, Seems the patch ignore the slight modification on that memory figure, So commit message isn`t consistent with the patch content. And actually I missed to remove a space between 7000 and 8000, since I removed a "-" -- Yours Sincerely, Cao jin