From: Cristina Ciocan <cristina.ciocan@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Irina Tirdea <irina.tirdea@intel.com>,
Octavian Purdila <octavian.purdila@intel.com>
Subject: Re: [PATCH v4 6/6] pinctrl: baytrail: Add debounce configuration
Date: Tue, 5 Apr 2016 14:18:19 +0300 [thread overview]
Message-ID: <57039EFB.4080508@intel.com> (raw)
In-Reply-To: <CACRpkdZUbO6yTkh67fZwhjd9DmMU7ZuF9xOM8bgu-O9jVaYcmA@mail.gmail.com>
On 04.04.2016 17:17, Linus Walleij wrote:
> On Fri, Apr 1, 2016 at 1:00 PM, Cristina Ciocan
> <cristina.ciocan@intel.com> wrote:
>
>> Make debounce setting and getting functionality available when
>> configurating a certain pin.
>>
>> Signed-off-by: Cristina Ciocan <cristina.ciocan@intel.com>
>
> Patch applied.
>
> And as this is another case where GPIO has a debounce
> setting call: gpiod_set_debounce() this is another case for
> my suggested pinctrl_gpio_set_config() as that call is
> currently not implemented in your corresponding .set_debounce()
> callback for the GPIO chip, but could easily be handled
> by calling back into the pinctrl back-end, right?
>
Yes, it can be easily handled by calling back byt_pin_config_set. I will
look into what other options are often used and would make sense to be
exported in the gpio layer as well and come back with a more detailed
answer.
Thanks
next prev parent reply other threads:[~2016-04-05 11:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 11:00 [PATCH v4 0/6] Add pinctrl support for Baytrail Cristina Ciocan
2016-04-01 11:00 ` [PATCH v4 1/6] pinctrl: baytrail: Add pin control data structures Cristina Ciocan
2016-04-04 13:57 ` Linus Walleij
2016-04-01 11:00 ` [PATCH v4 2/6] pinctrl: baytrail: Add pin control operations Cristina Ciocan
2016-04-04 14:00 ` Linus Walleij
2016-04-01 11:00 ` [PATCH v4 3/6] pinctrl: baytrail: Update gpio chip operations Cristina Ciocan
2016-04-04 14:08 ` Linus Walleij
2016-04-05 8:48 ` Mika Westerberg
2016-04-05 9:23 ` Cristina Ciocan
2016-04-01 11:00 ` [PATCH v4 4/6] pinctrl: baytrail: Update irq " Cristina Ciocan
2016-04-04 14:11 ` Linus Walleij
2016-04-01 11:00 ` [PATCH v4 5/6] pinctrl: baytrail: Register pin control handling Cristina Ciocan
2016-04-04 14:13 ` Linus Walleij
2016-04-01 11:00 ` [PATCH v4 6/6] pinctrl: baytrail: Add debounce configuration Cristina Ciocan
2016-04-04 14:17 ` Linus Walleij
2016-04-05 11:18 ` Cristina Ciocan [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-01 10:56 [PATCH v4 0/6] Add pinctrl support for Baytrail Cristina Ciocan
2016-04-01 10:56 ` [PATCH v4 6/6] pinctrl: baytrail: Add debounce configuration Cristina Ciocan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57039EFB.4080508@intel.com \
--to=cristina.ciocan@intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=irina.tirdea@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=octavian.purdila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.