From: Sebastian Andrzej Siewior <sebastian.siewior@linutronix.de>
To: rcochran@linutronix.de, Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Anna-Maria Gleixner <anna-maria@linutronix.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
rt@linutronix.de
Subject: Re: [PREEMPT-RT] [PATCH] s390/cpum_sf: Remove superfluous SMP function call
Date: Tue, 5 Apr 2016 13:57:42 +0200 [thread overview]
Message-ID: <5703A836.7030708@linutronix.de> (raw)
In-Reply-To: <20160405115129.GE30124@linutronix.de>
On 04/05/2016 01:51 PM, rcochran@linutronix.de wrote:
> On Tue, Apr 05, 2016 at 01:36:38PM +0200, Heiko Carstens wrote:
>> On Tue, Apr 05, 2016 at 01:23:36PM +0200, Heiko Carstens wrote:
>>> Subsequently, in this case, the setup_pmc_cpu() call will be executed on
>>> the wrong cpu.
>>
>> .. or to illustrate this behaviour: the following patch (white space
>> damaged due to copy-paste) results in the following:
>
> I guess you are missing the following commit?
…
> cpu/hotplug: Move online calls to hotplugged cpu
No, Heiko is right here. If one of the "CPU_DOWN_PREPARE" fails then
the following CPU_DOWN_FAILED will be invoked on the correct CPU.
However if we are further down the road and the final ARCH specific
"die" failed (just before CPU_DYING) are invoked then we get this done
on the wrong CPU.
> Thanks,
> Richard
Sebastian
next prev parent reply other threads:[~2016-04-05 11:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 10:27 [PATCH] s390/cpum_sf: Remove superfluous SMP function call Anna-Maria Gleixner
2016-04-05 10:49 ` Heiko Carstens
2016-04-05 11:13 ` [PREEMPT-RT] " Sebastian Andrzej Siewior
2016-04-05 11:23 ` Heiko Carstens
2016-04-05 11:36 ` Heiko Carstens
2016-04-05 11:51 ` rcochran
2016-04-05 11:55 ` Heiko Carstens
2016-04-05 11:57 ` Sebastian Andrzej Siewior [this message]
2016-04-05 12:11 ` Heiko Carstens
2016-04-05 12:19 ` Sebastian Andrzej Siewior
2016-04-05 15:59 ` [PATCH] cpu/hotplug: fix rollback during error-out in __cpu_disable() Sebastian Andrzej Siewior
2016-04-06 19:51 ` Heiko Carstens
2016-04-07 15:14 ` Sebastian Andrzej Siewior
2016-04-08 6:19 ` Heiko Carstens
2016-04-08 12:40 ` [PATCH v2] " Sebastian Andrzej Siewior
2016-04-22 7:54 ` [tip:smp/urgent] cpu/hotplug: Fix " tip-bot for Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5703A836.7030708@linutronix.de \
--to=sebastian.siewior@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=rcochran@linutronix.de \
--cc=rt@linutronix.de \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.