From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anQGV-0001pp-C2 for qemu-devel@nongnu.org; Tue, 05 Apr 2016 08:39:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anQGU-0004Q9-Iu for qemu-devel@nongnu.org; Tue, 05 Apr 2016 08:39:27 -0400 Sender: Paolo Bonzini References: <1459519058-29864-1-git-send-email-famz@redhat.com> <20160404115734.GA10964@stefanha-x1.localdomain> <20160405012739.GA670@ad.usersys.redhat.com> <20160405093956.GC2015@stefanha-x1.localdomain> <20160405111514.GA28766@ad.usersys.redhat.com> From: Paolo Bonzini Message-ID: <5703B1F4.5070707@redhat.com> Date: Tue, 5 Apr 2016 14:39:16 +0200 MIME-Version: 1.0 In-Reply-To: <20160405111514.GA28766@ad.usersys.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] block: Fix bdrv_drain in coroutine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , Stefan Hajnoczi Cc: Kevin Wolf , lvivier@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org On 05/04/2016 13:15, Fam Zheng wrote: > > Anyway, let's consider bdrv_drain() legacy code that can call if > > (qemu_in_coroutine()) but please make bdrv_co_drain() public so > > block/mirror.c can at least call it directly. > OK, will do. Please create a bdrv_co_drained_begin() function too, even if it's not used yet. Paolo