From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.01.org
Subject: Re: [PATCH] dbus: Avoid EPOLL_CTL_ADD on kdbus fd before hello command
Date: Tue, 05 Apr 2016 10:13:14 -0500 [thread overview]
Message-ID: <5703D60A.1000007@gmail.com> (raw)
In-Reply-To: <1459821880-7050-1-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 775 bytes --]
Hi Andrew,
On 04/04/2016 09:04 PM, Andrew Zaborowski wrote:
> Reorder the kdbus initialisation to avoid epoll_ctl(fd, EPOLL_CTL_ADD,
> ...) being called (from watch_add in l_io_new in dbus_init) before
> KDBUS_CMD_HELLO is sent. On the kernel side the kdbus handle is in the
> BUS_OWNER state until the hello command changes is to CONNECTED state,
> and will exit from f_ops->poll and not do anything to make epoll work.
> handle->conn is created only once in CONNECTED state but only the
> first f_ops->poll call by a given eventpoll has a chance to add the
> handle->conn->wait to its poll table.
> ---
> ell/dbus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied, thanks.
Does kdbus work reliably now?
Regards,
-Denis
prev parent reply other threads:[~2016-04-05 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 2:04 [PATCH] dbus: Avoid EPOLL_CTL_ADD on kdbus fd before hello command Andrew Zaborowski
2016-04-05 15:13 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5703D60A.1000007@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.