From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: Issues with the xen-access.c model Date: Tue, 5 Apr 2016 17:10:45 +0100 Message-ID: <5703E385.4060904@citrix.com> References: <570399A2.4090507@bitdefender.com> <5703ABF3.4040709@citrix.com> <5703DFF7.6040108@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5703DFF7.6040108@bitdefender.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Razvan Cojocaru , Tamas K Lengyel Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org T24gMDUvMDQvMTYgMTY6NTUsIFJhenZhbiBDb2pvY2FydSB3cm90ZToKPiBPbiAwNC8wNS8xNiAx ODozNSwgVGFtYXMgSyBMZW5neWVsIHdyb3RlOgo+Pgo+PiBPbiBUdWUsIEFwciA1LCAyMDE2IGF0 IDY6MTMgQU0sIEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20KPj4gPG1h aWx0bzphbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPj4gd3JvdGU6Cj4+Cj4+ICAgICBPbiAwNS8w NC8xNiAxMTo1NSwgUmF6dmFuIENvam9jYXJ1IHdyb3RlOgo+PiAgICAgPiBIZWxsbywKPj4gICAg ID4KPj4gICAgID4geGVuLWFjY2Vzcy5jIGRvZXMgcm91Z2hseSB0aGlzOgo+PiAgICAgPgo+PiAg ICAgPiBmb3IgKDs7KSB7Cj4+ICAgICA+ICAgICAgIHBvbGxfZXZ0X2NoYW5uZWwoKTsKPj4gICAg ID4KPj4gICAgID4gICAgICAgaWYgKG5ld19ldmVudHMpIHsKPj4gICAgID4gICAgICAgICAgICAg ICB3aGlsZSAocmluZ19idWZmZXJfaGFzX3JlcXVlc3RzKSB7Cj4+ICAgICA+ICAgICAgICAgICAg ICAgICAgICAgICBwdWxsX3JlcXVlc3QoKTsKPj4gICAgID4gICAgICAgICAgICAgICAgICAgICAg IHByb2Nlc3NfcmVxdWVzdCgpOwo+PiAgICAgPiAgICAgICAgICAgICAgICAgICAgICAgcHV0X3Jl c3BvbnNlKCk7Cj4+ICAgICA+ICAgICAgICAgICAgICAgfQo+PiAgICAgPgo+PiAgICAgPiAgICAg ICAgICAgICAgIHNpZ25hbF9ldnRfY2hhbm5lbCgpOwo+PiAgICAgPiAgICAgICB9Cj4+ICAgICA+ IH0KPj4gICAgID4KPj4gICAgID4gVGhlIHByb2JsZW1zIGFyZSB0aGVzZToKPj4gICAgID4KPj4g ICAgID4gMS4gdm1fZXZlbnRfcHV0X3JlcXVlc3QoKSBkb2VzIG5vdGlmeV92aWFfeGVuX2V2ZW50 X2NoYW5uZWwoZCwKPj4gICAgID4gdmVkLT54ZW5fcG9ydCk7IGF0IHRoZSB2ZXJ5IGVuZCwgYW5k IHdlIHNlZW0gdG8gYmUgdXNpbmcgYSBGSUZPIGV2ZW50Cj4+ICAgICA+IGNoYW5uZWwgKGlmIEkn bSByZWFkaW5nIHRoZSBjb2RlIHJpZ2h0LCBpdCdzIGdlbmVyaWMgZXZlbnQgY2hhbm5lbAo+PiAg ICAgY29kZQo+PiAgICAgPiB0aGF0IHByZS1kYXRlcyB0aGUgdm1fZXZlbnQgY29kZSB0aGF0IHNp dHMgb24gdG9wIG9mIGl0KS4KPj4gICAgID4KPj4gICAgID4gVGhpcyBtZWFucyB0aGF0IGZvciBh IGd1ZXN0IHRoYXQncyBydW5uaW5nIHR3byBWQ1BVcywgdGhlIGZvbGxvd2luZwo+PiAgICAgPiBz Y2VuYXJpbyBpcyBwb3NzaWJsZToKPj4gICAgID4KPj4gICAgID4gKiBWQ1BVMSBwdXRzIGFuIGV2 ZW50IGluIHRoZSByaW5nIGJ1ZmZlcgo+PiAgICAgPiAqIFZDUFUxIHNpZ25hbHMgdGhlIGV2ZW50 IGNoYW5uZWwKPj4gICAgID4gKiBwb2xsX2V2dF9jaGFubmVsKCkgd2FrZXMgdXAKPj4gICAgID4g KiBWQ1BVMiBwdXRzIGFuIGV2ZW50IGluIHRoZSByaW5nIGJ1ZmZlcgo+PiAgICAgPiAqIHRoZSBs b29wIHByb2Nlc3NlcyB0aGUgZmlyc3QgZXZlbnQKPj4gICAgID4gKiBWQ1BVMiBzaWduYWxzIHRo ZSBldmVudCBjaGFubmVsCj4+ICAgICA+ICogdGhlIGxvb3AgcHJvY2Vzc2VzIHRoZSBzZWNvbmQg ZXZlbnQgKHNpbmNlIHRoZXJlIF9hcmVfIG1vcmUgcmVxdWVzdHMKPj4gICAgID4gaW4gdGhlIHJp bmcgYnVmZmVyKQo+PiAgICAgPiAqIHRoZSBsb29wIHNpZ25hbHMgdGhlIGV2ZW50IGNoYW5uZWwg dGhhdCByZXF1ZXN0cyBoYXZlIGJlZW4gcHJvY2Vzc2VkCj4+ICAgICA+ICogcG9sbF9ldnRfY2hh bm5lbCgpIHdha2VzIHVwIGFnYWluLCBiZWNhdXNlIG9mIHRoZSBzZWNvbmQgZXZlbnQKPj4gICAg IGNoYW5uZWwKPj4gICAgID4gc2lnbmFsLCBidXQgdGhpcyBpcyBwb2ludGxlc3Mgc2luY2UgYWxs IGV2ZW50cyBoYXZlIGFscmVhZHkgYmVlbgo+PiAgICAgcHJvY2Vzc2VkCj4+ICAgICA+Cj4+ICAg ICA+IFRoaXMgY2FuIGJlIGF2b2lkZWQgYnkgY291bnRpbmcgdGhlIHJlcXVlc3RzIHByb2Nlc3Nl ZCB2cy4gdGhlCj4+ICAgICBudW1iZXIgb2YKPj4gICAgID4gc3VjY2VzZnVsIHBvbGwoKXMsIGJ1 dCBpdCBzdGlsbCBkb2VzIG5vdCBzb2x2ZSB0aGUgc2Vjb25kIHByb2JsZW06Cj4+ICAgICA+Cj4+ ICAgICA+IDIuIFJhY2UgY29uZGl0aW9ucy4gQXQgbGVhc3QgaW4gdGhlb3J5LCB0aGVyZSdzIG5v dGhpbmcgdG8gc3RvcCB0aGUKPj4gICAgID4gc2Vjb25kIGl0ZXJhdGlvbiBvZiB0aGUgcmVxdWVz dCBwcm9jZXNzaW5nIGxvb3AgdG8gcmVhZCBhIHBhcnRpYWxseQo+PiAgICAgPiB3cml0dGVuIHJl cXVlc3QgZnJvbSB0aGUgcmluZyBidWZmZXIsIG9yIGdhcmJhZ2UgbGVmdCBvdmVyIGZyb20gYQo+ PiAgICAgPiBwcmV2aW91cyByZXF1ZXN0LCBpZiBpdCBoaXRzIGl0ICJqdXN0IHJpZ2h0IiAoaS5l LiB0aGUgIlZDUFUyIHB1dHMgYW4KPj4gICAgID4gZXZlbnQgaW4gdGhlIHJpbmcgYnVmZmVyIiBw YXJ0IGNhbiBydW4gb24gdG9wIG9mIHRoZSAidGhlIGxvb3AKPj4gICAgIHByb2Nlc3Nlcwo+PiAg ICAgPiB0aGUgc2Vjb25kIGV2ZW50IikuCj4+ICAgICA+Cj4+ICAgICA+IEFsbCB0aGlzIGRvZXNu J3QgcmVhbGx5IHNob3cgdXAgdW5sZXNzIHdlJ3JlIGluIGhlYXZ5IHByb2Nlc3NpbmcKPj4gICAg ID4gc2NlbmFyaW9zLCBidXQgdGhleSBjYW4gb2NjdXIsIGVzcGVjaWFsbHkgaW4gc3luY2VkIHZt X2V2ZW50Cj4+ICAgICBzY2VuYXJpb3MuCj4+ICAgICA+Cj4+ICAgICA+IFRoZSBwcm9ibGVtcyBz ZWVtcyB0byBiZSBhbGxldmlhdGVkIGJ5IGNoYW5naW5nIHRoZSBsb29wIHRvIHRoaXM6Cj4+ICAg ICA+Cj4+ICAgICA+IGZvciAoOzspIHsKPj4gICAgID4gICAgICAgcG9sbF9ldnRfY2hhbm5lbCgp Owo+PiAgICAgPgo+PiAgICAgPiAgICAgICBpZiAobmV3X2V2ZW50cykgewo+PiAgICAgPiAgICAg ICAgICAgICAgIHdoaWxlIChyaW5nX2J1ZmZlcl9oYXNfcmVxdWVzdHMpIHsKPj4gICAgID4gICAg ICAgICAgICAgICAgICAgICAgIHB1bGxfcmVxdWVzdCgpOwo+PiAgICAgPiAgICAgICAgICAgICAg ICAgICAgICAgcHJvY2Vzc19yZXF1ZXN0KCk7Cj4+ICAgICA+ICAgICAgICAgICAgICAgICAgICAg ICBwdXRfcmVzcG9uc2UoKTsKPj4gICAgID4KPj4gICAgID4gICAgICAgICAgICAgICAgICAgICAg IC8qIE1vdmVkIGhlcmUuICovCj4+ICAgICA+ICAgICAgICAgICAgICAgICAgICAgICBzaWduYWxf ZXZ0X2NoYW5uZWwoKTsKPj4KPj4KPj4gVGhhdCB3YXMgdGhlIG9yaWdpbmFsIHNldHVwLCBJJ3Zl IGNoYW5nZWQgaXQgYSB3aGlsZSBiYWNrIGJ5IG1vdmluZyBpdAo+PiBvdXRzaWRlIHRoZSBsb29w LiBNeSByZWFzb25pbmcgd2FzIHRoYXQgdGhlcmUgaXMgbm8gcG9pbnQgaW4gZ29pbmcKPj4gbG9j a3N0ZXAgd2l0aCBldmVudHMgYW5kIGlzc3VpbmcgYSBoeXBlcmNhbGwgYWZ0ZXIgZWFjaCBpcyBw cm9jZXNzZWQuCj4+IFdpdGggb25seSBhIGhhbmRmdWwgb2YgZXZlbnRzIG9uIHRoZSByaW5nIHRo ZSBjb250ZXh0IHN3aXRjaCBpcyBwcm9iYWJseQo+PiBtb3JlIHRheGluZyB0aGVuIGhhdmluZyBh bGwgcmVxdWVzdHMgYW5kIHJlc3BvbnNlcyBwcm9jZXNzZWQgaW4gb25lCj4+IHN3aXBlLiBPZiBj b3Vyc2UsIGRlcGVuZGluZyBvbiB0aGUgYXBwbGljYXRpb24gdGhpcyBtYXkgbm90IGJlIHRoZQo+ PiBvcHRpbWFsIGNhc2UgYW5kIHRoZSBzaWduYWwgY2FuIGJlIG1vdmVkIGJhY2sgdG8gdGhlIGxv b3AgKHdpdGggbG90cyBvZgo+PiB2Q1BVcyBpdCBtYXkgYmUgdGhlIGNhc2UgdGhhdCB0aGUgZmly c3QgdkNQVSByZW1haW5zIHBhdXNlZCB3aGlsZSBhbGwKPj4gZXZlbnRzIGFyZSBwcm9jZXNzZWQg Zm9yIHRoZSBvdGhlciB2Q1BVcywgd2hpY2ggb2YgY291cnNlIHdvdWxkIGJlIGJhZCkuCj4+ICAK Pj4KPj4gICAgID4gICAgICAgICAgICAgICB9Cj4+ICAgICA+ICAgICAgIH0KPj4gICAgID4gfQo+ PiAgICAgPgo+PiAgICAgPiBidXQgaXQncyBvYnZpb3VzbHkgbm90IGZvb2xwcm9vZiwgdGhlIG1h aW4gcHJvYmxlbSByZW1haW5pbmcgdGhlCj4+ICAgICA+IHN5bmNocm9uaXphdGlvbiBvZiB0aGUg cmluZyBidWZmZXIgZnJvbSBib3RoIHRoZSBoeXBlcnZpc29yIHNpZGUgYW5kCj4+ICAgICA+IHVz ZXJzcGFjZS4KPj4gICAgID4KPj4gICAgID4gSG93IHNob3VsZCB3ZSBwcm9jZWVkIHRvIGZpeCB0 aGlzPwo+Pgo+PiAgICAgVGhlIHZtX2V2ZW50IGNvZGUgaW4gWGVuIG11c3QgaW5jcmVtZW50IHRo ZSBwcm9kdWNlciBpbmRleCBhcyB0aGUgZmluYWwKPj4gICAgIGFjdGlvbiBvZiBwdXR0aW5nIGEg cmVxdWVzdCBvbiB0aGUgcmluZy4gIElmIGl0IGRvZXNuJ3QgdGhlbiBpdCBpcwo+PiAgICAgc2lt cGx5IGJyb2tlbiBhbmQgbmVlZHMgZml4aW5nLgo+Pgo+PiAgICAgVGhpcyB3aWxsIGVuc3VyZSB0 aGF0IHRoZSBjb25zdW1lciBuZXZlciBzZWVzIGEgcGFydGlhbCByZXF1ZXN0IG9uIHRoZQo+PiAg ICAgcmluZzsgYnkgdGhlIHRpbWUgaXQgb2JzZXJ2ZXMgYSBuZXdlciBwcm9kdWNlciBpbmRleCwg YWxsIGRhdGEgaXMKPj4gICAgIGFscmVhZHkgd3JpdHRlbi4KPj4KPj4KPj4gSXQgbWF5IHdvcnRo IGRvdWJsZS1jaGVja2luZyBidXQgSSdtIHByZXR0eSBzdXJlIHRoYXQncyBob3cgaXQgd29ya3MK Pj4gcmlnaHQgbm93IGFzIHRoYXQgcGFydCBvZiB0aGUgY29kZSBoYXMgYmVlbiBwcmV0dHkgbXVj aCBqdXN0IGJlZW4KPj4gcmVjeWNsZWQgZnJvbSB0aGUgb3RoZXIgWGVuIHJpbmcgaW1wbGVtZW50 YXRpb25zLgo+IEkgdW5kZXJzdGFuZC4gV2Ugc2hvdWxkbid0IGZvcmdldCB0aGF0IHRoZSBjb25z dW1lciBhbHNvIG1vZGlmaWVzIHRoZQo+IHJpbmcgaW4gdXNlcnNwYWNlLCBhbmQgdGhlIGh5cGVy dmlzb3IgdGhlbiBiZWNvbWVzIGEgY29uc3VtZXIgb2YKPiByZXNwb25zZXMsIGFuZCB0aGUgc2Ft ZSBpc3N1ZXMgYXBwbHkgdG8gaXQgKHdvdWxkIGNvbXBpbGVyIG9wdGltaXphdGlvbnMKPiBiZSBh IHByb2JsZW0gaGVyZT8pLgoKUXVpdGUgcG9zc2libHkuICBTZWUgWFNBLTE1NQoKPiBCdXQgdW5s ZXNzIHRoYXQncyB0aGUgY2FzZSwgdGhlbiBJJ20gcHJvYmFibHkgc2VlaW5nIGEgZGlmZmVyZW50 IGlzc3VlIGFuZCBBbmRyZXcgaXMgcmlnaHQuCj4KPiBUaGFuayB5b3UgYm90aCBmb3IgdGhlIHBy b21wdCByZXBsaWVzIQoKWW91IG5lZWQgdG8gbWFrZSBjZXJ0YWluIHRoYXQgZm9yIGJvdGggcHJv ZHVjZXIvY29uc3VtZXIgcGFpcnMsIHRoZQpmb2xsb3dpbmcgaXMgdHJ1ZToKClRoZSBwcm9kdWNl ciBhbmQgY29uc3VtZXIgaW5kaWNlcyBhcmUgcmVhZCB1c2luZyBzb21lIGZvcm0gb2YgYXRvbWlj Cm9wZXJhdGlvbiAoQUNDRVNTX09OQ0UoKSBtb3N0IGxpa2VseSwgb3IgcmVhZF9hdG9taWMoKSks IGZvbGxvd2VkIGJ5IGFuCnNtYl9ybWIoKSB0byBndWFyYW50ZWUgdGhhdCB0aGUgcmVhZCBjb21w bGV0ZXMgYW5kIGlzIGluIGEgbG9jYWwKdmFyaWFibGUgYmVmb3JlIGFueSBjYWxjdWxhdGlvbiBp cyBwZXJmb3JtZWQgYmFzZWQgb24gdGhlIHZhbHVlLiAgKFRoaXMKcHJldmVudHMgdGhlIGNvbXBp bGVyICJvcHRpbWlzaW5nIiB0byBtdWx0aXBsZSByZWFkcyBvZiB0aGUgc2hhcmVkIHJpbmcpLgoK VGhlbiwgbWVtY3B5KCkgKG9yIHN1aXRhYmxlIGFsdGVybmF0aXZlKSB0byBnZXQgdGhlIGNvbnRl bnRzIG9mIHRoZQpyZXF1ZXN0IGluL291dCBvZiB0aGUgcmluZy4KCkZvciB0aGUgcHJvZHVjZXIg c2lkZSwgYW4gc21wX3dtYigpIGJldHdlZW4gdGhlIG1lbWNweSgpIGludG8gdGhlIHJpbmcsCmFu ZCB0aGUgd3JpdGUgdG8gdGhlIHByb2R1Y2VyIGluZGV4LgpGb3IgdGhlIGNvbnN1bWVyIHNpZGUs IGFuIHNtcF9tYigpIGJldHdlZW4gdGhlIG1lbWNweSgpIG91dCBvZiB0aGUgcmluZywKYW5kIHRo ZSB3cml0ZSB0byB0aGUgY29uc3VtZXIgaW5kZXguCgp+QW5kcmV3CgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhl bi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=