Re: [PATCH] NetLabel: Introduce a new kernel configuration API for NetLabel - For 2.6.24-rc-git11 - Smack Version 10

[Casey Schaufler <casey@schaufler-ca.com>]

--- Joshua Brindle <method@manicmethod.com> wrote:

> Joshua Brindle wrote:
> > Casey Schaufler wrote:
> >> From: Paul Moore <paul.moore@hp.com>
> >>
> >> Add a new set of configuration functions to the NetLabel/LSM API so that
> >> LSMs can perform their own configuration of the NetLabel subsystem 
> >> without
> >> relying on assistance from userspace.
> >>   
> > I'm still not receiving the actual patch email on lsm (perhaps its too 
> > long and should be split up..) so I'll just respond on this email. 
> > Using the v10 patches on your website I'm still seeing strange 
> > behavior where echo foo > /proc/self/attr/current changes the label of 
> > every process on the system to foo (verified with both ps -AZ and cat 
> > /proc/1/attr/current).
> >
> Actually I'm getting more strange behavior:
> 
> On terminal 1 I do:
> echo foo > /proc/self/attr/current
> then ps -AZ shows foo for every process
> touch somefile; attr -S -g SMACK64 somefile says foo
> 
> On terminal 2 I do:
> ps -AZ and everything shows up as _
> cat /proc/$pid of bash on term 1/attr/current is _

Now this I can explain. Every task has it's own correct
label. The problem is a missing smack_getprocattr() hook.
ps is getting the value for "current" on the current process,
not that of the named process. Interestingly, the Smack label
of /proc/<xxx>/attr/current is correct.

So the fix is to put in the smack_getprocattr() hook.
Easily accomplished. Thank you for the informative and
helpful report.


Casey Schaufler
casey@schaufler-ca.com