From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 0F456E00C62; Wed, 6 Apr 2016 01:48:11 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.0 SPF_HELO_PASS SPF: HELO matches SPF record * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from ptmx.org (ptmx.org [178.63.28.110]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 62F97E00C5B for ; Wed, 6 Apr 2016 01:48:10 -0700 (PDT) Received: from [172.16.1.4] (chello062178118086.5.14.vie.surfer.at [62.178.118.86]) by ptmx.org (Postfix) with ESMTPSA id 0B77A38896; Wed, 6 Apr 2016 10:48:08 +0200 (CEST) To: Gary Bisson References: <1459928193-4771-1-git-send-email-dv@pseudoterminal.org> <5704C8CE.2090908@pseudoterminal.org> From: Carlos Rafael Giani Message-ID: <5704CD48.3090504@pseudoterminal.org> Date: Wed, 6 Apr 2016 10:48:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Cc: meta-freescale@yoctoproject.org Subject: Re: [meta-fsl-arm][PATCH] gstreamer1.0-plugins-imx: Update to version 0.12.1 X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2016 08:48:11 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2016-04-06 10:43, Gary Bisson wrote: > -# gstreamer1.0-plugins-bad is in DEPENDS because imxv4l2videosrc > requires > -# the GstPhotography headers and libraries > -DEPENDS = "gstreamer1.0 gstreamer1.0-plugins-base > gstreamer1.0-plugins-bad imx-gpu-viv \ > - libfslcodec libimxvpuapi virtual/kernel virtual/egl > virtual/libgles2 \ > - ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', > '', d)}" > +# gstreamer1.0-plugins-bad is in DEPENDS because the build script scans > for the > +# GstPhotography headers and libraries > +DEPENDS = "gstreamer1.0 gstreamer1.0-plugins-base > gstreamer1.0-plugins-bad virtual/kernel" >>> Shouldn't plugins-bad be a dependency for v4l2src only? >> >> The configuration switches only switch on/off the actual plugins (and their >> immediate dependencies, like GLES libraries, or libimxvpuapi). >> And, gstphotography is a dependency-less component of -bad. In the -bad >> tree, gstphotography can be found in gst-libs/ , while stuff that has >> external dependencies is in ext/. >> What this means is that gstphotography is *not* enabled/disabled by the >> v4l2src switch in the build script. This is intentional - dependency-less >> GStreamer *libraries* might be used by more than one gstreamer-imx plugin in >> the future, which is why they are autoconfigured in the root build script. >> (For example, gstreamer-video-1.0 is used by the vpu plugins as well as the >> ipu and pxp ones.) >> If I put -bad as a v4l2src dependency, then the build script would still >> scan for gstphotography if you turn off the v4l2src plugin. bitbake would >> then print a warning that -bad is a dependency but is not part of the >> DEPENDS list. > Ok, I didn't know the plugin would throw a warning on that dependency, > we don't want a warning for sure. > What confused me is the comment since it clearly states that > plugins-bad is for imxv4l2videosrc. True, this could be confusing. This is why I changed the comment ;-) > Here is what I think it should look like: > PACKAGECONFIG_mx6q = "eglvivsink g2d ipu mp3encoder pxp uniaudiocodec > v4l2src vpu" > PACKAGECONFIG_mx6dl = "eglvivsink g2d ipu mp3encoder pxp uniaudiocodec > v4l2src vpu" > PACKAGECONFIG_mx6sx = "eglvivsink g2d mp3encoder pxp uniaudiocodec v4l2src" > PACKAGECONFIG_mx6sl = "g2d mp3encoder pxp uniaudiocodec v4l2src" > PACKAGECONFIG_mx7 = "mp3encoder pxp uniaudiocodec v4l2src" > > I've ordered the flags alphabetically, feel free to change it. > > Regards, > Gary Thanks, this helps. (uniaudiodec, not uniaudiocodec, but I'll rename that in the v2 recipe.) Also, if anybody can try this on older SoCs such as an imx5, I would welcome patches, both for the recipe and for gstreamer-imx itself :-) Carlos