From: Ian Abbott <abbotti@mev.co.uk>
To: Hartley Sweeten <HartleyS@visionengravers.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH] staging: comedi: das1800: remove unused variable
Date: Wed, 6 Apr 2016 10:41:01 +0100 [thread overview]
Message-ID: <5704D9AD.4050807@mev.co.uk> (raw)
In-Reply-To: <BY1PR0101MB1063637B91DA95A4B7FE6140D09F0@BY1PR0101MB1063.prod.exchangelabs.com>
On 06/04/16 02:21, Hartley Sweeten wrote:
> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote:
>> The variable unipolar was never used.
>>
>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>> ---
>>
>> There may be a chance that reading from DAS1800_CONTROL_C is necessary
>> before reading from DAS1800_STATUS. If that is true then please discard
>> this patch.
>
> Actually the driver has a bug here.
>
> The analog input samples should be munged if the inputs are configured for
> bipolar mode.
>
> I have a series almost ready that cleans up this driver and fixes the bug.
Hi Hartley, can the bug fix be placed at the top of your patch series?
Thanks.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2016-04-06 9:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 14:23 [PATCH] staging: comedi: das1800: remove unused variable Sudip Mukherjee
2016-04-06 1:21 ` Hartley Sweeten
2016-04-06 9:41 ` Ian Abbott [this message]
2016-04-06 10:40 ` Ian Abbott
2016-04-06 17:55 ` Hartley Sweeten
2016-04-06 16:19 ` Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5704D9AD.4050807@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=HartleyS@visionengravers.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.