From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43099)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ankH2-0003Sg-EY
	for qemu-devel@nongnu.org; Wed, 06 Apr 2016 06:01:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ankGy-0006gK-Ku
	for qemu-devel@nongnu.org; Wed, 06 Apr 2016 06:01:20 -0400
Received: from smtp.mail.uni-mannheim.de ([134.155.96.80]:59251)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ankGy-0006fk-ED
	for qemu-devel@nongnu.org; Wed, 06 Apr 2016 06:01:16 -0400
References: <1458631893-12812-1-git-send-email-sw@weilnetz.de>
	<20160406091619.GO16305@toto>
From: Stefan Weil <sw@weilnetz.de>
Message-ID: <5704DE6D.1020902@weilnetz.de>
Date: Wed, 6 Apr 2016 12:01:17 +0200
MIME-Version: 1.0
In-Reply-To: <20160406091619.GO16305@toto>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] disas/microblaze: Add missing 'const'
 attributes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: qemu-devel@nongnu.org

Am 06.04.2016 um 11:16 schrieb Edgar E. Iglesias:
> On Tue, Mar 22, 2016 at 08:31:33AM +0100, Stefan Weil wrote:
>> Making the opcode list 'const' saves memory.
>> Some function arguments and local variables needed 'const', too.
>>
>> Add also 'static' to two local functions.
> Hi Stefan,
>
> Sorry for the delays...
>
> I gave this a try but it fails for me:
>
> /home/edgar/src/c/qemu/qemu/disas/microblaze.c:668:1: error: conflictin=
g types for =E2=80=98get_field_special=E2=80=99
>  get_field_special(long instr, const struct op_code_struct *op)
>  ^
> /home/edgar/src/c/qemu/qemu/disas/microblaze.c:599:8: note: previous de=
claration of =E2=80=98get_field_special=E2=80=99 was here
>  char * get_field_special (long instr, struct op_code_struct * op);
>         ^
> /home/edgar/src/c/qemu/qemu/disas/microblaze.c:733:1: error: conflictin=
g types for =E2=80=98read_insn_microblaze=E2=80=99
>  read_insn_microblaze (bfd_vma memaddr,=20
>  ^
> /home/edgar/src/c/qemu/qemu/disas/microblaze.c:600:15: note: previous d=
eclaration of =E2=80=98read_insn_microblaze=E2=80=99 was here
>  unsigned long read_insn_microblaze (bfd_vma memaddr,=20
>                ^
> make: *** [disas/microblaze.o] Error 1
> make: *** Waiting for unfinished jobs....
>
>
> It looks like if you may have forgotten to update or remove the functio=
n prototypes...
>
> Best regards,
> Edgar
>

Hello Edgar,

you are right, I forgot to remove the two function prototypes.
They are not needed, so removing is the best solution which
I also used in most of my working trees. Obviously I had
chosen a bad tree for sending the patch, sorry for that.

Should I send an update, or can you just remove the two
conflicting prototypes?

Thanks,
Stefan