From: Andrew Cooper <andrew.cooper3@citrix.com>
To: George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@citrix.com>, Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH 1/1] libxl: Fix uninitialized pointer when passing an empty cdrom
Date: Wed, 6 Apr 2016 13:10:37 +0100 [thread overview]
Message-ID: <5704FCBD.1010300@citrix.com> (raw)
In-Reply-To: <1459942446-25008-1-git-send-email-george.dunlap@citrix.com>
On 06/04/16 12:34, George Dunlap wrote:
> Commit 3fec17d4bb56567d139d7806392f4d8702d3f6a7 introduced a bug where
> an empty cdrom would cause target_path to be uninitialized. Initialize
> target_path to NULL instead.
>
> The other option here would have been to set target_path to NULL only
> on the LIBXL_DISK_FORMAT_EMPTY path. That would potentially enable
> the compiler to catch future uninitialized paths, rather than having
> those paths (potentially) dereference a NULL pointer. But given that
> a bunch of our compilers failed to catch *this* uninitialized path,
> setting it to NULL at declaration seems the safer option for now.
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
This looks like it will work. Reviewed-by: Andrew Cooper
<andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-06 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 11:34 [PATCH 1/1] libxl: Fix uninitialized pointer when passing an empty cdrom George Dunlap
2016-04-06 12:10 ` Andrew Cooper [this message]
2016-04-06 13:47 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5704FCBD.1010300@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.