From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH kvm-unit-tests] x86: access: check for PKU even for non-writable pages Date: Wed, 6 Apr 2016 23:11:18 +0800 Message-ID: <57052716.7070305@linux.intel.com> References: <1459930768-26035-1-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Paolo Bonzini , kvm@vger.kernel.org Return-path: Received: from mga11.intel.com ([192.55.52.93]:13075 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753733AbcDFPM5 (ORCPT ); Wed, 6 Apr 2016 11:12:57 -0400 In-Reply-To: <1459930768-26035-1-git-send-email-pbonzini@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/06/2016 04:19 PM, Paolo Bonzini wrote: > Xiao Guangrong ran kvm-unit-tests on an actual machine with PKU and > found that it fails: > > test pte.p pte.user pde.p pde.user pde.a pde.pse pkru.wd pkey=1 user write efer.nx cr4.pke: FAIL: error code 27 expected 7 > Dump mapping: address: 0x123400000000 > ------L4: 2ebe007 > ------L3: 2ebf007 > ------L2: 8000000020000a5 > > So PFEC.PKEY is set even if the ordinary check failed (which it did > because pde.w is zero). Adjust ac_test_permissions to match behavior > of silicon. It works. Reviewed-by: Xiao Guangrong