From: York Sun <york.sun@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc:fsl_esdhc: fix invalidate dcache scope
Date: Wed, 6 Apr 2016 08:26:20 -0700 [thread overview]
Message-ID: <57052A9C.2070209@nxp.com> (raw)
In-Reply-To: <1459937560-25607-1-git-send-email-Shengzhou.Liu@nxp.com>
On 04/06/2016 03:22 AM, Shengzhou Liu wrote:
> commit 4683b220655 "mmc:fsl_esdhc invalidate dcache before read"
> intended for ARM, which broke on PowerPC(caused memory allocation
> failure under SD boot), so add condition CONFIG_ARM.
>
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@nxp.com>
> ---
> drivers/mmc/fsl_esdhc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index 7cc61a0..7812e6c 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -348,8 +348,10 @@ esdhc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data)
> if(err)
> return err;
>
> +#ifdef CONFIG_ARM
> if (data->flags & MMC_DATA_READ)
> check_and_invalidate_dcache_range(cmd, data);
> +#endif
> }
>
> /* Figure out the transfer arguments */
>
Shenghzou,
This is not a correct fix. This issue is related to
http://lists.denx.de/pipermail/u-boot/2015-December/236272.html
http://lists.denx.de/pipermail/u-boot/2016-March/249377.html
In short, the invalidate_dcache_range function was added for
512x/5xxx/83xx/85xx. Although it shouldn't do any harm, it actually does. I
haven't got a chance to investigate. Please look into it if you can.
York
next prev parent reply other threads:[~2016-04-06 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 10:12 [U-Boot] [PATCH] mmc:fsl_esdhc: fix invalidate dcache scope Shengzhou Liu
2016-04-06 15:26 ` York Sun [this message]
2016-04-07 4:15 ` Shengzhou Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57052A9C.2070209@nxp.com \
--to=york.sun@nxp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.