From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anpwx-00024S-SK for qemu-devel@nongnu.org; Wed, 06 Apr 2016 12:05:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anpwu-0007A6-LC for qemu-devel@nongnu.org; Wed, 06 Apr 2016 12:04:59 -0400 References: <1459848109-29756-1-git-send-email-silbe@linux.vnet.ibm.com> <1459848109-29756-5-git-send-email-silbe@linux.vnet.ibm.com> From: Max Reitz Message-ID: <5705339A.2050609@redhat.com> Date: Wed, 6 Apr 2016 18:04:42 +0200 MIME-Version: 1.0 In-Reply-To: <1459848109-29756-5-git-send-email-silbe@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5RtW0VtuQkMc1cNc0OQPmxDRkSfeXXSPN" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] qemu-iotests: 148: properly skip test if quorum support is missing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sascha Silbe , qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf Cc: Tu Bo This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5RtW0VtuQkMc1cNc0OQPmxDRkSfeXXSPN Content-Type: multipart/mixed; boundary="LISr7E0gOm8eTDl6Rt47O1eUqkrMGhgnt" From: Max Reitz To: Sascha Silbe , qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf Cc: Tu Bo Message-ID: <5705339A.2050609@redhat.com> Subject: Re: [Qemu-block] [PATCH 4/7] qemu-iotests: 148: properly skip test if quorum support is missing References: <1459848109-29756-1-git-send-email-silbe@linux.vnet.ibm.com> <1459848109-29756-5-git-send-email-silbe@linux.vnet.ibm.com> In-Reply-To: <1459848109-29756-5-git-send-email-silbe@linux.vnet.ibm.com> --LISr7E0gOm8eTDl6Rt47O1eUqkrMGhgnt Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 05.04.2016 11:21, Sascha Silbe wrote: > qemu-iotests test case 148 already had some code for skipping the test > if quorum support is missing, but it didn't work in all > cases. TestQuorumEvents.setUp() gets run before the actual test class > (which contains the skipping code) and tries to start qemu with a drive= > using the quorum driver. For some reason this works fine when using > qcow2, but fails for raw. >=20 > As the entire test case requires quorum, just check for availability > before even starting the test suite. Introduce a verify_quorum() > function in iotests.py for this purpose so future test cases can make > use of it. >=20 > Signed-off-by: Sascha Silbe > Reviewed-by: Bo Tu > --- > tests/qemu-iotests/148 | 4 +--- > tests/qemu-iotests/iotests.py | 5 +++++ > 2 files changed, 6 insertions(+), 3 deletions(-) Reviewed-by: Max Reitz --LISr7E0gOm8eTDl6Rt47O1eUqkrMGhgnt-- --5RtW0VtuQkMc1cNc0OQPmxDRkSfeXXSPN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXBTOaAAoJEDuxQgLoOKytzMwH/Ri6Tn+IFChNosG4+K/81uG5 L3T/6rObvbGEYed3Z5jmiVa5gr9PMecbfewq0V+X8BL2XVzkJp1kD8bDJntzRiop gMLrsK3AxjQhs0RMr6wqgVDvz5KVazMWRLhayqINxYCULUuYqK7KxuCCNvPNdjfA nH4ZYoZ9xRYY/xydqXnBhPy4bCAO8PKoWMNC1wtZTxDle0NE3hGUM88x+tE2NGus RY5XWa8eauuCI7fzJpJ0LplclYUKmDpML46czvR/MujkIG4Ml/cfRy7IuynG0JdW 6mxQPgnLr2ciEfM9mpsgEBrfaVW1CX3h+jIdMo+24SNu8qNbFl+YxE8h3ULLQ9I= =/Wd+ -----END PGP SIGNATURE----- --5RtW0VtuQkMc1cNc0OQPmxDRkSfeXXSPN--