From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH] drm: bridge: analogix/dp: fix no drm hpd event when panel plug in Date: Thu, 7 Apr 2016 12:19:01 +0800 Message-ID: <5705DFB5.4010602@rock-chips.com> References: <1460002529-30719-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1460002529-30719-1-git-send-email-ykk@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie , Mark Yao , Heiko Stuebner Cc: devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org U29ycnkgZm9yIGRpc3R1cmIsIEkgbWFrZSBhIG1pc3Rha2VuIGFib3V0IHRoZQpyZWNlaXZlIGxp c3QsIHBsZWFzZSBpZ25vcmUgdGhpcyBlbWFpbC4KCi0gWWFraXIKCk9uIDA0LzA3LzIwMTYgMTI6 MTUgUE0sIFlha2lyIFlhbmcgd3JvdGU6Cj4gVGhlIGVudW0gdmFsdWUgb2YgRFBfSVJRX1RZUEVf SFBfQ0FCTEVfSU4gaXMgemVybywgYnV0IGRyaXZlciBvbmx5Cj4gc2VuZCBkcm0gaHAgZXZlbnQg d2hlbiB0aGUgaXJxX3R5cGUgYW5kIHRoZSBlbnVtIHZhbHVlIGlzIHRydWUuCj4KPiBpZiAoaXJx X3R5cGUgJiBEUF9JUlFfVFlQRV9IUF9DQUJMRV9JTiB8fCAuLi4pCj4gCWRybV9oZWxwZXJfaHBk X2lycV9ldmVudChkcC0+ZHJtX2Rldik7Cj4KPiBTbyB0aGVyZSB3b3VsZCBubyBkcm0gaHBkIGV2 ZW50IHdoZW4gY2FibGUgcGx1ZyBpbiwgdG8gZml4IHRoYXQKPiBqdXN0IG5lZWQgdG8gYXNzaWdu IGFsbCBob3RwbHVnIGVudW0gd2l0aCBuby16ZXJvIHZhbHVlcy4KPgo+IFJlcG9ydGVkLWJ5OiBE YW4gQ2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+Cj4gU2lnbmVkLW9mZi1ieTog WWFraXIgWWFuZyA8eWtrQHJvY2stY2hpcHMuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJt L2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9jb3JlLmggfCA4ICsrKystLS0tCj4gICAxIGZp bGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfY29yZS5oIGIv ZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9jb3JlLmgKPiBpbmRl eCBmMDkyNzVkLi5iNDU2MzgwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uv YW5hbG9naXgvYW5hbG9naXhfZHBfY29yZS5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRn ZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9jb3JlLmgKPiBAQCAtMTI3LDEwICsxMjcsMTAgQEAgZW51 bSBhbmFsb2dfcG93ZXJfYmxvY2sgewo+ICAgfTsKPiAgIAo+ICAgZW51bSBkcF9pcnFfdHlwZSB7 Cj4gLQlEUF9JUlFfVFlQRV9IUF9DQUJMRV9JTiwKPiAtCURQX0lSUV9UWVBFX0hQX0NBQkxFX09V VCwKPiAtCURQX0lSUV9UWVBFX0hQX0NIQU5HRSwKPiAtCURQX0lSUV9UWVBFX1VOS05PV04sCj4g KwlEUF9JUlFfVFlQRV9IUF9DQUJMRV9JTiAgPSBCSVQoMCksCj4gKwlEUF9JUlFfVFlQRV9IUF9D QUJMRV9PVVQgPSBCSVQoMSksCj4gKwlEUF9JUlFfVFlQRV9IUF9DSEFOR0UgICAgPSBCSVQoMiks Cj4gKwlEUF9JUlFfVFlQRV9VTktOT1dOICAgICAgPSBCSVQoMyksCj4gICB9Owo+ICAgCj4gICBz dHJ1Y3QgdmlkZW9faW5mbyB7CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Thu, 7 Apr 2016 12:19:01 +0800 Subject: [PATCH] drm: bridge: analogix/dp: fix no drm hpd event when panel plug in In-Reply-To: <1460002529-30719-1-git-send-email-ykk@rock-chips.com> References: <1460002529-30719-1-git-send-email-ykk@rock-chips.com> Message-ID: <5705DFB5.4010602@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Sorry for disturb, I make a mistaken about the receive list, please ignore this email. - Yakir On 04/07/2016 12:15 PM, Yakir Yang wrote: > The enum value of DP_IRQ_TYPE_HP_CABLE_IN is zero, but driver only > send drm hp event when the irq_type and the enum value is true. > > if (irq_type & DP_IRQ_TYPE_HP_CABLE_IN || ...) > drm_helper_hpd_irq_event(dp->drm_dev); > > So there would no drm hpd event when cable plug in, to fix that > just need to assign all hotplug enum with no-zero values. > > Reported-by: Dan Carpenter > Signed-off-by: Yakir Yang > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > index f09275d..b456380 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > @@ -127,10 +127,10 @@ enum analog_power_block { > }; > > enum dp_irq_type { > - DP_IRQ_TYPE_HP_CABLE_IN, > - DP_IRQ_TYPE_HP_CABLE_OUT, > - DP_IRQ_TYPE_HP_CHANGE, > - DP_IRQ_TYPE_UNKNOWN, > + DP_IRQ_TYPE_HP_CABLE_IN = BIT(0), > + DP_IRQ_TYPE_HP_CABLE_OUT = BIT(1), > + DP_IRQ_TYPE_HP_CHANGE = BIT(2), > + DP_IRQ_TYPE_UNKNOWN = BIT(3), > }; > > struct video_info { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbcDGETZ (ORCPT ); Thu, 7 Apr 2016 00:19:25 -0400 Received: from lucky1.263xmail.com ([211.157.147.131]:35605 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751655AbcDGETW (ORCPT ); Thu, 7 Apr 2016 00:19:22 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-KSVirus-check: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <7de7059e1be5f633fca346c92efe7ca2> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] drm: bridge: analogix/dp: fix no drm hpd event when panel plug in To: David Airlie , Mark Yao , Heiko Stuebner References: <1460002529-30719-1-git-send-email-ykk@rock-chips.com> Cc: Joonyoung Shim , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <5705DFB5.4010602@rock-chips.com> Date: Thu, 7 Apr 2016 12:19:01 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1460002529-30719-1-git-send-email-ykk@rock-chips.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry for disturb, I make a mistaken about the receive list, please ignore this email. - Yakir On 04/07/2016 12:15 PM, Yakir Yang wrote: > The enum value of DP_IRQ_TYPE_HP_CABLE_IN is zero, but driver only > send drm hp event when the irq_type and the enum value is true. > > if (irq_type & DP_IRQ_TYPE_HP_CABLE_IN || ...) > drm_helper_hpd_irq_event(dp->drm_dev); > > So there would no drm hpd event when cable plug in, to fix that > just need to assign all hotplug enum with no-zero values. > > Reported-by: Dan Carpenter > Signed-off-by: Yakir Yang > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > index f09275d..b456380 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > @@ -127,10 +127,10 @@ enum analog_power_block { > }; > > enum dp_irq_type { > - DP_IRQ_TYPE_HP_CABLE_IN, > - DP_IRQ_TYPE_HP_CABLE_OUT, > - DP_IRQ_TYPE_HP_CHANGE, > - DP_IRQ_TYPE_UNKNOWN, > + DP_IRQ_TYPE_HP_CABLE_IN = BIT(0), > + DP_IRQ_TYPE_HP_CABLE_OUT = BIT(1), > + DP_IRQ_TYPE_HP_CHANGE = BIT(2), > + DP_IRQ_TYPE_UNKNOWN = BIT(3), > }; > > struct video_info {