From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-de.keymile.com (mail-de.keymile.com [195.8.104.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3qgXPS3BVSzDq64 for ; Thu, 7 Apr 2016 16:14:51 +1000 (AEST) Subject: Re: [PATCH] powerpc: define the fman node for the kmcoge4 DTS To: Scott Wood , "linuxppc-dev@lists.ozlabs.org" References: <1459949825-10533-1-git-send-email-valentin.longchamp@keymile.com> <1459979380.32510.75.camel@buserror.net> From: Valentin Longchamp Message-ID: <5705FAD3.40106@keymile.com> Date: Thu, 7 Apr 2016 08:14:43 +0200 MIME-Version: 1.0 In-Reply-To: <1459979380.32510.75.camel@buserror.net> Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 06/04/16 23:49, Scott Wood wrote: > On Wed, 2016-04-06 at 15:37 +0200, Valentin Longchamp wrote: >> Now that the FMAN mac driver has been merged the fman node is relevant. >> >> The kmcoge4 board implements 3 ethernet interfaces, 1 with a RGMII phy >> and 2 with fixed 1 Giga SGMII links. >> >> Signed-off-by: Valentin Longchamp >> --- >> arch/powerpc/boot/dts/fsl/kmcoge4.dts | 39 >> +++++++++++++++++++++++++++++++++++ >> 1 file changed, 39 insertions(+) >> >> diff --git a/arch/powerpc/boot/dts/fsl/kmcoge4.dts >> b/arch/powerpc/boot/dts/fsl/kmcoge4.dts >> index 6858ec9..1cec66d 100644 >> --- a/arch/powerpc/boot/dts/fsl/kmcoge4.dts >> +++ b/arch/powerpc/boot/dts/fsl/kmcoge4.dts >> @@ -106,6 +106,45 @@ >> sata@221000 { >> status = "disabled"; >> }; >> + >> + fman0: fman@400000 { >> + enet0: ethernet@e0000 { >> + phy-connection-type = "sgmii"; >> + local-mac-address = [00 11 22 33 44 55]; >> + fixed-link { >> + speed = <1000>; >> + full-duplex; >> + }; >> + }; >> + mdio0: mdio@e1120 { >> + front_phy: ethernet-phy@11 { >> + reg = <0x11>; >> + }; >> + }; >> + >> + enet1: ethernet@e2000 { >> + phy-connection-type = "sgmii"; >> + local-mac-address = [00 11 22 33 44 56]; >> + fixed-link { >> + speed = <1000>; >> + full-duplex; >> + }; >> + }; > > No hardcoded MAC addresses. > For these 2 interfaces where I have the local-mac-address field, the MAC addresses are set later by an application that reads the real address in some EEPROM. However, in order to let the fman mac_probe to run successfully in the first place I have set non-zero MAC addresses since the local-mac-address fields are not set by u-boot. I have found several local-mac-address fields in other DTS files that are all zeros, and thus are rejected by of_get_mac_address. Are they leftovers from the past or should they be used here as well ? If not, I will simply drop these 2 fields. Thanks Valentin