All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wojciech Nizinski <niziak@spox.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] new package: alsacap
Date: Thu, 7 Apr 2016 09:35:56 +0200	[thread overview]
Message-ID: <57060DDC.1000702@spox.org> (raw)
In-Reply-To: <570590D7.30005@mind.be>

Is any tool available to check format of BR files (something like vera++) ?

On 07.04.2016 00:42, Arnout Vandecappelle wrote:
>  In addition to Yegor's comments...
>
> On 04/06/16 09:01, Wojciech Nizinski wrote:
>> Alsa capability tool displays the capabilities of your sound card and
>> its ALSA driver
>>
>> Signed-off-by: Wojciech Nizinski <niziak@spox.org>
>> ---
>>   package/Config.in          |  1 +
>>   package/alsacap/Config.in  |  5 +++++
>>   package/alsacap/alsacap.mk | 22 ++++++++++++++++++++++
>>   3 files changed, 28 insertions(+)
>>   create mode 100644 package/alsacap/Config.in
>>   create mode 100644 package/alsacap/alsacap.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index bdc3063..dd6c1d9 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -5,6 +5,7 @@ menu "Target packages"
>>
>>   menu "Audio and video applications"
>>       source "package/alsa-utils/Config.in"
>> +    source "package/alsacap/Config.in"
>>       source "package/aumix/Config.in"
>>       source "package/bellagio/Config.in"
>>       source "package/dvblast/Config.in"
>> diff --git a/package/alsacap/Config.in b/package/alsacap/Config.in
>> new file mode 100644
>> index 0000000..d472973
>> --- /dev/null
>> +++ b/package/alsacap/Config.in
>> @@ -0,0 +1,5 @@
>> +config BR2_PACKAGE_ALSACAP
>> +    bool "alsacap"
>> +    depends on BR2_PACKAGE_ALSA_LIB
>
>  Use select instead of depends:
>
>     depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
>     select BR2_PACKAGE_ALSA_LIB
>
>  Because there is a dependency on threads, you also need to add a 
> comment to clarify that (cfr. the manual).
>
>> +    help
>> +        Alsa capability tool displays the capabilities of your sound 
>> card and its ALSA driver.
>
>  Indentation should be 1 tab + 2 spaces, and wrap at 72 columns (where 
> tab counts for 8, so 62 characters).
>
>> diff --git a/package/alsacap/alsacap.mk b/package/alsacap/alsacap.mk
>> new file mode 100644
>> index 0000000..391947c
>> --- /dev/null
>> +++ b/package/alsacap/alsacap.mk
>> @@ -0,0 +1,22 @@
>> +################################################################################ 
>>
>> +#
>> +# alsacap
>> +#
>> +################################################################################ 
>>
>> +ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
>> +ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
>> +
>
>  Remove this empty line.
>
>> +ALSACAP_LICENSE = ISC licence
>> +ALSACAP_LICENSE_FILES = COPYING
>> +
>
>  Here as well.
>
>
>  Regards,
>  Arnout
>
>> +ALSACAP_DEPENDENCIES = alsa-lib
>> +
>> +define ALSACAP_BOOTSTRAP
>> +    cd $(@D) && ./bootstrap
>> +endef
>> +
>> +ALSACAP_PRE_CONFIGURE_HOOKS += ALSACAP_BOOTSTRAP
>> +
>> +$(eval $(autotools-package))
>> +
>> +
>>
>
>

  reply	other threads:[~2016-04-07  7:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06  7:01 [Buildroot] [PATCH 1/1] new package: alsacap Wojciech Nizinski
2016-04-06  7:10 ` Yegor Yefremov
2016-04-06 14:37   ` Wojciech Niziński
2016-04-07  7:39     ` Jerzy Grzegorek
2016-07-03  7:36     ` Peter Korsgaard
2016-04-06 22:42 ` Arnout Vandecappelle
2016-04-07  7:35   ` Wojciech Nizinski [this message]
2016-04-10 14:40     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57060DDC.1000702@spox.org \
    --to=niziak@spox.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.