From: Arnd Bergmann <arnd@arndb.de>
To: John Youn <John.Youn@synopsys.com>
Cc: Christian Lamparter <chunkeey@googlemail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"a.seppala@gmail.com" <a.seppala@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Felipe Balbi <balbi@ti.com>,
Douglas Anderson <dianders@chromium.org>,
Gregory Herrero <gregory.herrero@intel.com>,
Mian Yousaf Kaukab <yousaf.kaukab@intel.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v3] usb: dwc2: fix regression on big-endian PowerPC/ARM systems
Date: Fri, 13 May 2016 15:48:14 +0200 [thread overview]
Message-ID: <5706100.G8QoS78uJd@wuerfel> (raw)
In-Reply-To: <573574F2.8010901@synopsys.com>
On Thursday 12 May 2016 23:32:18 John Youn wrote:
>
> Hi Arnd,
>
> The capitalization issue is still there in this patch.
>
> There's also a few checkpatch issues.
Fixed now, thanks. I'll send a v4 in a bit.
> And should the barrier be moved after the write like it says in the
> comment? That seems to have been removed since earlier versions of
> the patch.
I've clarified the comment, so we refer to the __raw_writel
not the writel. It's also possible that this was just another
bug in the patch that broke powerpc, but I don't know anything
about MIPS barrier semantics, so I prefer not to touch that.
Arnd
prev parent reply other threads:[~2016-05-13 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 20:56 [PATCH v3] usb: dwc2: fix regression on big-endian PowerPC/ARM systems Arnd Bergmann
2016-05-13 6:32 ` John Youn
2016-05-13 13:48 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5706100.G8QoS78uJd@wuerfel \
--to=arnd@arndb.de \
--cc=John.Youn@synopsys.com \
--cc=a.seppala@gmail.com \
--cc=balbi@ti.com \
--cc=benh@kernel.crashing.org \
--cc=chunkeey@googlemail.com \
--cc=dianders@chromium.org \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.herrero@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=yousaf.kaukab@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.