From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ao5dz-0003LZ-5v for qemu-devel@nongnu.org; Thu, 07 Apr 2016 04:50:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ao5du-0001RZ-6c for qemu-devel@nongnu.org; Thu, 07 Apr 2016 04:50:27 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:34412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ao5dt-0001RR-W7 for qemu-devel@nongnu.org; Thu, 07 Apr 2016 04:50:22 -0400 Received: by mail-wm0-x244.google.com with SMTP id n3so19569424wmn.1 for ; Thu, 07 Apr 2016 01:50:21 -0700 (PDT) Sender: Paolo Bonzini References: <1459961962-18771-1-git-send-email-eblake@redhat.com> <1459982918-32229-1-git-send-email-eblake@redhat.com> From: Paolo Bonzini Message-ID: <57061F4B.5050704@redhat.com> Date: Thu, 7 Apr 2016 10:50:19 +0200 MIME-Version: 1.0 In-Reply-To: <1459982918-32229-1-git-send-email-eblake@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/1 for-2.6] nbd: Don't kill server when client requests unknown option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: alex@alex.org.uk On 07/04/2016 00:48, Eric Blake wrote: > nbd-server.c currently fails to handle unsupported options properly. > If during option haggling the client sends an unknown request, the > server kills the connection instead of letting the client try to > fall back to something older. This is precisely what advertising > NBD_FLAG_FIXED_NEWSTYLE was supposed to fix. > > Signed-off-by: Eric Blake > --- > > Turns out our server has a very similar bug to the client. > If desired, I can spin a v3 that moves the hunk in nbd/client.c > to the previous patch. I'll do that myself. Thanks for the patches! Paolo