Re: [PATCH v3] xen/arm: map_dev_mmio_region: printk should be ratelimited

[Julien Grall <julien.grall@arm.com>]

Hi Shannon,

On 07/04/16 07:28, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> The function map_dev_mmio_region is used in a hypercall. Therefore all
> printks should be ratelimited to avoid a malicious guest flooding the
> console.
>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Acked-by: Julien Grall <julien.grall@arm.com>

Regards,

> ---
> v3: update commit message
> ---
>   xen/arch/arm/p2m.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 0011708..db21433 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -1284,7 +1284,7 @@ int map_dev_mmio_region(struct domain *d,
>       res = map_mmio_regions(d, start_gfn, nr, mfn);
>       if ( res < 0 )
>       {
> -        printk(XENLOG_ERR "Unable to map [%#lx - %#lx] in Dom%d\n",
> +        printk(XENLOG_G_ERR "Unable to map [%#lx - %#lx] in Dom%d\n",
>                  start_gfn, start_gfn + nr - 1, d->domain_id);
>           return res;
>       }
>

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel