All of lore.kernel.org
 help / color / mirror / Atom feed
From: Loic Dachary <loic@dachary.org>
To: Thierry Delamare <t.delamare@laposte.net>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: aarch64 conditional ansible stanza
Date: Thu, 7 Apr 2016 16:07:32 +0200	[thread overview]
Message-ID: <570669A4.2010309@dachary.org> (raw)
In-Reply-To: <5706679B.6030606@laposte.net>



On 07/04/2016 15:58, Thierry Delamare wrote:
> 
> 
> On 04/07/2016 08:46 AM, Loic Dachary wrote:
>> Hi Thierry,
>>
>> In order to only install a template on architectures that are not aarch64, I changed
>>
>> - name: Add sources list
>>    template:
>>      dest: /etc/apt/sources.list
>>      src: "../../templates/apt/sources.list.{{ ansible_distribution_release | lower }}"
>>      owner: root
>>      group: root
>>      mode: 0644
>>    register: sources
>>
>> into
>>
>> - name: Add sources list
>>    template:
>>      dest: /etc/apt/sources.list
>>      src: "../../templates/apt/sources.list.{{ ansible_distribution_release | lower }}"
>>      owner: root
>>      group: root
>>      mode: 0644
>>    register: sources
>>    when: {{ansible_architecture}} != aarch64
>>
>> Is there a better way to do that ?
> Bonjour Loic,
> 
> Using when statement is the correct way to add conditions to a task,
> but don't forget that the when clause contains a Jinja2 expression (not like a module argument),
> Thus the correct expression should rather be « when: ansible_architecture != 'aarch64' ».

Indeed, the previous attempt failed :-) Here is a more elaborate version that also excludes some packages that are not available in the aarch64 repositories. How does that look ?

https://github.com/ceph/ceph-cm-ansible/pull/224/commits/80e1cb2f3688393f4238268a543e6c3ab19bae75

-- 
Loïc Dachary, Artisan Logiciel Libre
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-04-07 14:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07  6:46 aarch64 conditional ansible stanza Loic Dachary
2016-04-07 13:58 ` Thierry Delamare
2016-04-07 14:07   ` Loic Dachary [this message]
2016-04-07 15:49     ` Thierry Delamare
2016-04-07 16:09       ` Loic Dachary
2016-04-07 16:35         ` Thierry Delamare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570669A4.2010309@dachary.org \
    --to=loic@dachary.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=t.delamare@laposte.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.