All of lore.kernel.org
 help / color / mirror / Atom feed
From: gpiccoli@linux.vnet.ibm.com (Guilherme G. Piccoli)
Subject: [PATCH] Avoid reset work on watchdog timer function during error recovery
Date: Thu, 7 Apr 2016 12:42:29 -0300	[thread overview]
Message-ID: <57067FE5.7060002@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160407142449.GA9586@localhost.localdomain>



On 04/07/2016 11:24 AM, Keith Busch wrote:
> On Thu, Apr 07, 2016@06:11:31AM -0700, Christoph Hellwig wrote:
>> static bool nvme_should_reset(struct nvme_dev *dev)
>> {
>> 	u32 csts = readl(dev->bar + NVME_REG_CSTS);
>>
>> 	if (!(csts & NVME_CSTS_CFS) &&
>> 	    !((dev->subsystem && (csts & NVME_CSTS_NSSRO))))
>> 		return false;
>>
>> 	if (work_pending(&dev->reset_work))
>> 		return false;
>> 	if (work_busy(&dev->reset_work))
>> 		return false;
>
> We could also skip checking work_pending since work_busy does that for us.
>

Great! What name should/can I choose for the function?

Thanks,


Guilherme

  reply	other threads:[~2016-04-07 15:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06 20:30 [PATCH] Avoid reset work on watchdog timer function during error recovery Guilherme G. Piccoli
2016-04-06 20:50 ` Keith Busch
2016-04-07  8:05 ` Johannes Thumshirn
2016-04-07 13:11 ` Christoph Hellwig
2016-04-07 13:17   ` Guilherme G. Piccoli
2016-04-07 13:18   ` Sagi Grimberg
2016-04-07 13:26     ` Christoph Hellwig
2016-04-07 14:24   ` Keith Busch
2016-04-07 15:42     ` Guilherme G. Piccoli [this message]
2016-04-07 15:46       ` Keith Busch
2016-04-07 16:03         ` Guilherme G. Piccoli
2016-04-12 19:01           ` Christoph Hellwig
2016-04-12 23:33             ` Guilherme G. Piccoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57067FE5.7060002@linux.vnet.ibm.com \
    --to=gpiccoli@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.