From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH 0/4] IB/srpt and the percpu_ida conversion Date: Thu, 7 Apr 2016 15:38:25 -0700 Message-ID: <5706E161.9000006@sandisk.com> References: <57055BC6.7070402@sandisk.com> <1460068181.18732.23.camel@haakon3.risingtidesystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1460068181.18732.23.camel-XoQW25Eq2zviZyQQd+hFbcojREIfoBdhmpATvIKMPHk@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Nicholas A. Bellinger" Cc: Doug Ledford , Christoph Hellwig , Sagi Grimberg , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , target-devel List-Id: linux-rdma@vger.kernel.org On 04/07/2016 03:29 PM, Nicholas A. Bellinger wrote: > The whole point of the alloc_session callback is so that extra > pre-allocation doesn't happen until after se_node_acl lookup has > finished, and is what ib_srpt needs to be using given SRP's completely > existent spec level security model. Sorry but I consider this as hair splitting. Who cares about whether or not command buffer allocation + freeing happens for login attempts that will fail because no ACL has been set up yet? That scenario is not performance critical. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html