From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756428AbcDGXjG (ORCPT ); Thu, 7 Apr 2016 19:39:06 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:58791 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328AbcDGXjD (ORCPT ); Thu, 7 Apr 2016 19:39:03 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68f-f79c86d0000012ad-ca-5706ef9447e5 Content-transfer-encoding: 8BIT Message-id: <5706EF94.6010903@samsung.com> Date: Fri, 08 Apr 2016 08:39:00 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Roger Quadros , myungjoo.ham@samsung.com Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] extcon: usb-gpio: Don't miss event during suspend/resume References: <1459951299-20578-1-git-send-email-rogerq@ti.com> In-reply-to: <1459951299-20578-1-git-send-email-rogerq@ti.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42JZI2JSojvlPVu4wf41KhaXd81hs7jduILN oueRlgOzR9+WVYwex29sZ/L4vEkugDmKyyYlNSezLLVI3y6BK2P11TbGgokcFd+3tbA1MN5h 62Lk4JAQMJFYc9Coi5ETyBSTuHBvPVCYi0NIYAWjxPqzzewQCROJLy1HGCESSxklXnzqYgVJ 8AoISvyYfI8FZBCzgLzEkUvZIGFmAXWJSfMWMUPUP2CUuPu4gwmiXkvixOUuNhCbRUBVYuL3 PWBz2IDi+1/cADtIVCBCovtEJYgpImAtseG7D8RIBYlf9zaBVQsL+Ersu/kA7DQhAVuJr20f mUFsTgE7ies9rUwgayUElrFLrOhfywKxSkDi2+RDLBD/ykpsOsAM8ZakxMEVN1gmMIrNQvLM LIRnZiF5ZgEj8ypG0dSC5ILipPQiY73ixNzi0rx0veT83E2MwIg5/e9Z/w7GuwesDzEKcDAq 8fBadLKGC7EmlhVX5h5iNAU6YiKzlGhyPjAu80riDY3NjCxMTUyNjcwtzZTEeRdK/QwWEkhP LEnNTk0tSC2KLyrNSS0+xMjEwSnVwKiY/cJG+mz45K1rp/2uEZvgnLqryHH1Hel9zRdYrpud NTbjV9XcekCiz08iZe/v3b2HvVK+zgx9IX8zJ3cj03+n2Px9x/a+io5Yevz79fe8zN9rJ/+q 3Xmz9cCcPmmFffMWBhWcP7xR7vitRJtnTelztF9OV58sfl1hi1SPmGXs9sN/gm9u3yuoxFKc kWioxVxUnAgAZeK0A5MCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsVy+t9jAd0p79nCDX4tl7W4vGsOm8XtxhVs Fj2PtByYPfq2rGL0OH5jO5PH501yAcxRDYw2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6 hpYW5koKeYm5qbZKLj4Bum6ZOUCLlBTKEnNKgUIBicXFSvp2mCaEhrjpWsA0Ruj6hgTB9RgZ oIGENYwZq6+2MRZM5Kj4vq2FrYHxDlsXIyeHhICJxJeWI4wQtpjEhXvrgeJcHEICSxklXnzq YgVJ8AoISvyYfI+li5GDg1lAXuLIpWyQMLOAusSkeYuYIeofMErcfdzBBFGvJXHichfYAhYB VYmJ3/eAzWEDiu9/cYMNZI6oQIRE94lKEFNEwFpiw3cfiJEKEr/ubQKrFhbwldh38wE7iC0k YCvxte0jM4jNKWAncb2nlWkCo8AsJMfNQjhuFpLjFjAyr2KUSC1ILihOSs81zEst1ytOzC0u zUvXS87P3cQIjstnUjsYD+5yP8QowMGoxMNr0ckaLsSaWFZcmXuIUYKDWUmEt+UFW7gQb0pi ZVVqUX58UWlOavEhRlOg7yYyS4km5wNTRl5JvKGxiZmRpZG5oYWRsbmSOO/j/+vChATSE0tS s1NTC1KLYPqYODilGhhLvF5NufV33w//dFWL2O5lW3iPzJ+9q71u0vrdJz9uXL1prruC8mS/ 0AczFvw49evoo0sSnxgeP1pZkJmvsvJDjZ7Dt2d3n02MUZb8u04tRfUC19FDlvdfCbw96bvD QNeFxzt7cfmcZawHxQI8dT9Hsduut1RaU6u3aI3UJ7H5v1bM6U5YPs05UYmlOCPRUIu5qDgR ALShC6zhAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 04월 06일 23:01, Roger Quadros wrote: > Pin state might have changed during suspend/resume while > our interrupts were disabled. Scan for change during resume. > > Signed-off-by: Roger Quadros > --- > drivers/extcon/extcon-usb-gpio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c > index 2b2fecf..20175ec 100644 > --- a/drivers/extcon/extcon-usb-gpio.c > +++ b/drivers/extcon/extcon-usb-gpio.c > @@ -192,6 +192,7 @@ static int usb_extcon_resume(struct device *dev) > } > > enable_irq(info->id_irq); > + usb_extcon_detect_cable(&info->wq_detcable.work); If interrupt is using as wakeup source/irq, after wake-up from suspend state, the interrupt handler will be handled. But, if interrupt is not used for wakeup source/irq, As your patch, we need to check the state on resume(). So, I think you need more condition to check the interrupt is whether wakeup source or not. Thanks, Chanwoo CHoi