From: Peter Hurley <peter@hurleysoftware.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
ismo.puustinen@intel.com,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v1 07/12] serial: 8250_dma: adjust DMA address of the UART
Date: Thu, 7 Apr 2016 17:24:59 -0700 [thread overview]
Message-ID: <5706FA5B.8050503@hurleysoftware.com> (raw)
In-Reply-To: <1460061433-63750-8-git-send-email-andriy.shevchenko@linux.intel.com>
On 04/07/2016 01:37 PM, Andy Shevchenko wrote:
> Some UARTs, e.g. one is used in Intel Quark, have a different address base for
> DMA operations. Introduce an additional field in struct uart_8250_dma to cover
> those cases.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/tty/serial/8250/8250.h | 2 ++
> drivers/tty/serial/8250/8250_dma.c | 5 +++--
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h
> index 047a7ba..040deb2 100644
> --- a/drivers/tty/serial/8250/8250.h
> +++ b/drivers/tty/serial/8250/8250.h
> @@ -31,6 +31,8 @@ struct uart_8250_dma {
> struct dma_chan *rxchan;
> struct dma_chan *txchan;
>
> + phys_addr_t dma_addr;
> +
Let's add separate rx and tx device addrs.
> dma_addr_t rx_addr;
> dma_addr_t tx_addr;
>
> diff --git a/drivers/tty/serial/8250/8250_dma.c b/drivers/tty/serial/8250/8250_dma.c
> index b134bec..a314492 100644
> --- a/drivers/tty/serial/8250/8250_dma.c
> +++ b/drivers/tty/serial/8250/8250_dma.c
> @@ -164,16 +164,17 @@ int serial8250_rx_dma(struct uart_8250_port *p, unsigned int iir)
> int serial8250_request_dma(struct uart_8250_port *p)
> {
> struct uart_8250_dma *dma = p->dma;
> + phys_addr_t dma_addr = dma->dma_addr ? dma->dma_addr : p->port.mapbase;
> dma_cap_mask_t mask;
>
> /* Default slave configuration parameters */
> dma->rxconf.direction = DMA_DEV_TO_MEM;
> dma->rxconf.src_addr_width = DMA_SLAVE_BUSWIDTH_1_BYTE;
> - dma->rxconf.src_addr = p->port.mapbase + UART_RX;
> + dma->rxconf.src_addr = dma_addr + UART_RX;
>
> dma->txconf.direction = DMA_MEM_TO_DEV;
> dma->txconf.dst_addr_width = DMA_SLAVE_BUSWIDTH_1_BYTE;
> - dma->txconf.dst_addr = p->port.mapbase + UART_TX;
> + dma->txconf.dst_addr = dma_addr + UART_TX;
>
> dma_cap_zero(mask);
> dma_cap_set(DMA_SLAVE, mask);
>
next prev parent reply other threads:[~2016-04-08 0:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 20:37 [PATCH v1 00/12] serial: 8250: split LPSS to 8250_lpss, enable DMA on Quark Andy Shevchenko
2016-04-07 20:37 ` [PATCH v1 01/12] dmaengine: dw: keep copy of custom slave config in dwc Andy Shevchenko
2016-04-07 20:37 ` [PATCH v1 02/12] dmaengine: dw: provide probe(), remove() stubs for users Andy Shevchenko
2016-04-07 20:37 ` [PATCH v1 03/12] dmaengine: dw: set polarity of handshake interface Andy Shevchenko
2016-04-07 20:37 ` [PATCH v1 04/12] dmaengine: dw: override LLP support if asked in platform data Andy Shevchenko
2016-04-07 20:37 ` [PATCH v1 05/12] serial: 8250_dma: switch to new dmaengine_terminate_* API Andy Shevchenko
2016-04-07 23:55 ` Peter Hurley
2016-04-07 20:37 ` [PATCH v1 06/12] serial: 8250_dma: stop ongoing RX DMA on exception Andy Shevchenko
2016-04-07 23:54 ` Peter Hurley
2016-04-08 8:07 ` Andy Shevchenko
2016-04-08 23:20 ` Peter Hurley
2016-04-07 20:37 ` [PATCH v1 07/12] serial: 8250_dma: adjust DMA address of the UART Andy Shevchenko
2016-04-08 0:24 ` Peter Hurley [this message]
2016-04-07 20:37 ` [PATCH v1 08/12] serial: 8250: enable AFE on ports where FIFO is 16 bytes Andy Shevchenko
2016-04-07 23:43 ` Peter Hurley
2016-04-07 20:37 ` [PATCH v1 09/12] serial: 8250_lpss: split LPSS driver to separate module Andy Shevchenko
2016-04-08 1:42 ` Peter Hurley
2016-04-08 8:17 ` Andy Shevchenko
2016-04-08 22:44 ` Peter Hurley
2016-04-11 13:09 ` Andy Shevchenko
2016-04-07 20:37 ` [PATCH v1 10/12] serial: 8250_lpss: move Quark code from PCI driver Andy Shevchenko
2016-04-07 20:37 ` [PATCH v1 11/12] serial: 8250_lpss: enable MSI for Intel Quark Andy Shevchenko
2016-04-07 20:37 ` [PATCH v1 12/12] serial: 8250_lpss: enable DMA on Intel Quark UART Andy Shevchenko
2016-04-11 15:33 ` Bryan O'Donoghue
2016-04-11 15:51 ` Andy Shevchenko
2016-04-11 16:05 ` Andy Shevchenko
2016-04-12 16:25 ` Bryan O'Donoghue
2016-04-12 16:50 ` Andy Shevchenko
2016-04-13 11:22 ` Bryan O'Donoghue
2016-04-13 12:03 ` Andy Shevchenko
2016-04-13 14:34 ` Bryan O'Donoghue
2016-04-13 14:48 ` Andy Shevchenko
2016-04-13 15:24 ` Bryan O'Donoghue
2016-04-09 16:53 ` [PATCH v1 00/12] serial: 8250: split LPSS to 8250_lpss, enable DMA on Quark Bryan O'Donoghue
2016-04-09 17:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5706FA5B.8050503@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=ismo.puustinen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.